Task #91117

Epic #87417: Integrate proper Content Security Policy (CSP) handling

Task #87418: Refactor and remove usage of inline scripts in backend

Use GlobalEventHandler and ActionDispatcher instead of inline JS

Added by Oliver Hader 3 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Security
Target version:
-
Start date:
2020-04-18
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Bug #91261: Broken funcmenu in BackendUtility::getFuncMenu Closed 2020-05-01

Associated revisions

Revision 1d0f8fce (diff)
Added by Oliver Hader 2 months ago

[TASK] Use GlobalEventHandler and ActionDispatcher instead of inline JS

This change aims to reduce the amount of inline JavaScript by
removing `onchange` or `onclick` events and dynamically created
JavaScript code/settings.

  • adjusts invocations of top.TYPO3.InfoWindow.showItem
  • adjusts low-level inline `onchange` and `onclick` events

Both JavaScript modules `TYPO3/CMS/Backend/GlobalEventHandler` and
`TYPO3/CMS/Backend/ActionDispatcher` are required to actually handle
these new triggers and correpsonding events - that's why they are
loaded in `ModuleTemplate` and deprecated `DocumentTemplate`.

Resolves: #91117
Releases: master
Change-Id: Ie7012445d09c3aee253548cb3057c8e9e4b86809
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64242
Tested-by: Josef Glatz <>
Tested-by: Benni Mack <>
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Josef Glatz <>
Reviewed-by: Benni Mack <>
Reviewed-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64242

#2 Updated by Gerrit Code Review 3 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64242

#3 Updated by Gerrit Code Review 3 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64242

#4 Updated by Gerrit Code Review 3 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64242

#5 Updated by Gerrit Code Review 3 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64242

#6 Updated by Gerrit Code Review 3 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64242

#7 Updated by Gerrit Code Review 3 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64242

#8 Updated by Gerrit Code Review 3 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64242

#9 Updated by Gerrit Code Review 2 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64242

#10 Updated by Oliver Hader 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#11 Updated by Benni Mack 2 months ago

  • Status changed from Resolved to Closed

#12 Updated by Georg Ringer 2 months ago

  • Related to Bug #91261: Broken funcmenu in BackendUtility::getFuncMenu added

Also available in: Atom PDF