Bug #91165
closedNew Content Element Wizard Modal not opening in modal box (if you are to fast)
100%
Description
Problem/Description¶
I can open the NCEW (triggered from any page module "+ Content" button between existing content elements) without a modal box the last couple of weeks testing/reviewing the TYPO3 master (10.4.x-dev to be specific) and also in real world 10.4.0 LTS projects at least "once" a day. Looks like a race-condition, where maybe any JS listener is to slow, I don't know I can reproduce it now!.
Since I had to get a feeling of when does that mostly appear, I can say now that it's mostly occurs when I do the following steps:
- I am logged in in my TYPO3 backend (Chrome, stable, macOS Mojave, DevTools are open with the Elements Tab, Caches are disabled checkbox is on in network tab)
- Page module is opened
- I close the editing mode of an content element
- the page module is reloading
- I see the typical page module with content elements on it
- I press on any "+ Content" button, but don't wait to long, click as soon as you see the buttons)
- I see the following scenario instead of the nice modal with the nice filter functionality:
Some other key points:
- I don't know if it also appears if I close the DevTools (I will check it while working on projects)
- I don't know if this only occurs on slow computers™ like mine ;-)
- The following console log entries exists (but I'm not sure if they exists because of this shown issue)
jquery.clearable.js?bust=1587483197:33 jquery.clearable has been marked as deprecated and will be removed in TYPO3 v11. Use TYPO3/CMS/Backend/Input/Clearable and native HTMLInputElement instead.
[Deprecation] Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.
- The content of the NCEW modal is loaded in the #typo3-contentIframe
Acceptance Criteria¶
- NCEW modal should open always in modal
NCEW ... New Content Element Wizard
Files
Updated by Josef Glatz over 4 years ago
- Subject changed from New Content Element Wizard Modal not opening in modal box (at least once a day) to New Content Element Wizard Modal not opening in modal box (if you are to fast)
- Description updated (diff)
Updated by Josef Glatz over 4 years ago
With some further testing I found out that someone don't have to be very fast to achieve that
Updated by Andreas Kienast over 4 years ago
- Status changed from Accepted to In Progress
Updated by Gerrit Code Review over 4 years ago
- Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64307
Updated by Gerrit Code Review over 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64307
Updated by Andreas Fernandez over 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 67f1f68f9683da4c885a08ded1b0e86e0017b80d.
Updated by Gerrit Code Review about 4 years ago
- Status changed from Closed to Under Review
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65090
Updated by Andreas Kienast about 4 years ago
- Related to Bug #91848: modal-dialog by create new content element is broken added
Updated by Gerrit Code Review about 4 years ago
Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65090
Updated by Andreas Fernandez about 4 years ago
- Status changed from Under Review to Resolved
Applied in changeset a0da229e4709210b1075ceca58ded5a55b569f56.