Project

General

Profile

Actions

Bug #91391

closed

SMTP encrypt setting migration not always correct

Added by Torben Hansen over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2020-05-14
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
mail
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

The migrate mail SMTP encrypt option does not always migrate the setting correctly. This resulted in exceptions sending emails using SMTP from TYPO3.

I had 3 sites (all v10 but < 10.4.2), where the initial value in LocalConfiguration.php was as shown below:

'transport_smtp_encrypt' => ''

With TYPO3 10.4.2, the migrator introduced in #91070 migrated this setting to:

'transport_smtp_encrypt' => true

The is_string check is not fully sufficient here, since under certain conditions (e.g. migrating from V9.5 to 10.4) the value is always a string. Therefore it should also be checked, if the string is empty and if so, transport_smtp_encrypt should be migrated to false


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #91070: SMTP transport 'tls' no longer work supportedClosed2020-04-16

Actions
Actions #1

Updated by Torben Hansen over 4 years ago

  • Related to Bug #91070: SMTP transport 'tls' no longer work supported added
Actions #2

Updated by Josef Glatz over 4 years ago

Possibly also important in this context:

I also wonder if it is intended that
  • the DefaultConfigurationDescription.yaml states that MAIL/transport_smtp_encrypt is a boolean value
  • but the MAIL/transport_smtp_encrypt value in DefaultConfiguration.php an empty string is.
Actions #3

Updated by Benjamin Franzke over 4 years ago

  • Status changed from New to Accepted
  • Assignee set to Benjamin Franzke
Actions #4

Updated by Georg Ringer over 4 years ago

  • Subject changed from STMP encrypt setting migration not always correct to SMTP encrypt setting migration not always correct
Actions #5

Updated by Gerrit Code Review over 4 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64490

Actions #6

Updated by Josef Glatz over 4 years ago

  • Tags set to mail
Actions #7

Updated by Benjamin Franzke over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF