Bug #91463

9.5.17 and 9.5.18 installtool error on php 7.2 / php 7.3

Added by Sabine Deeken over 1 year ago. Updated 11 months ago.

Status:
Accepted
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2020-05-25
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Hello,

last week I had problems with the 9.5.17 / 9.5.18 upgrade:
I could not open the installtool, neither via TYPO3-Backend, nor single.
The error-message:

Warning: A non-numeric value encountered in /[mypath]/typo3_src-9.5.18/typo3/sysext/core/Classes/Core/Bootstrap.php on line 673 {"success":true}

after hours of trying what could be the problem, ifound out that it was the php-Version.
it doesn't work with 7.2 and 7.3, but in 7.4 the error is gone.

for my site I can change the php-version, but it would have been good to know, and other users maybe can't.
so this would be worth to be fixed, wouldn't it?

with the best regards,
Sabine


Related issues

Related to TYPO3 Core - Bug #84105: Log writers configured in DefaultConfiguration.php cannot be easily removed/disabledClosed2018-03-01

Actions
#1

Updated by Andreas Fernandez over 1 year ago

  • Status changed from New to Needs Feedback

I remember I had this issue as well once. Do you by chance have empty ext_localconf.php or ext_tables.php files?

#2

Updated by Sabine Deeken over 1 year ago

Andreas Fernandez wrote:

I remember I had this issue as well once. Do you by chance have empty ext_localconf.php or ext_tables.php files?

I had an ext_tables.php, but it was not empty and in my test-installation I removed it and tried again with php7.2 .
Then I uninstalled all non sysext-extensions, and tried again, but no installtool still.

is an ext_localconf.php or ext_tables.php empty if there's only

<?php
defined('TYPO3_MODE') || die('Access denied.');

inside?

#3

Updated by Oliver Hader over 1 year ago

  • Target version deleted (9.5.18 & 10.4.3)
#4

Updated by Riccardo De Contardi 12 months ago

May I ask if this issue is still reproducible?

#5

Updated by Sabine Deeken 12 months ago

Riccardo De Contardi wrote:

May I ask if this issue is still reproducible?

Yes, it is. TYPO3 9.5.22, php 7.2 and 7.3.
php7.4 is working.

#6

Updated by Oliver Hader 11 months ago

Caused by https://review.typo3.org/c/Packages/TYPO3.CMS/+/64400/2/typo3/sysext/core/Classes/Core/Bootstrap.php (first released with TYPO3 v9.5.17)
→ which means that errorHandlerErrors setting in Sabine's is either not defined or not a numeric value (as the warning said)

#7

Updated by Oliver Hader 11 months ago

  • Status changed from Needs Feedback to Accepted
#8

Updated by Oliver Hader 11 months ago

  • Related to Bug #84105: Log writers configured in DefaultConfiguration.php cannot be easily removed/disabled added
#9

Updated by Oliver Hader 11 months ago

  • Is Regression changed from Yes to No

Not a regression, but misconfiguration in typo3conf/LocalConfiguration.php

The following example demonstrates what's actually going on here:

php > var_dump('string' | E_USER_DEPRECATED);
PHP Warning:  A non-numeric value encountered in php shell code on line 1

That means that TYPO3's default configuration for errorHandlerErrors (which is expected to be an integer) is overridden with a string in typo3conf/LocalConfiguration.php. That "worked" before, by implicitly casting to integer. In the long run that is wrong because actually merging default configuration with override configuration should validate those types first - and in case they don't match - log that problem and fallback to default configuration.

#10

Updated by Sabine Deeken 11 months ago

Oliver Hader wrote in #note-6:

Caused by https://review.typo3.org/c/Packages/TYPO3.CMS/+/64400/2/typo3/sysext/core/Classes/Core/Bootstrap.php (first released with TYPO3 v9.5.17)
→ which means that errorHandlerErrors setting in Sabine's is either not defined or not a numeric value (as the warning said)

I had:
E_ALL ^ E_WARNING
thanks, Oliver!

Also available in: Atom PDF