Project

General

Profile

Actions

Bug #92284

closed

<f:asset.script> ViewHelper double escape the src attribute

Added by Frank Nägler over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Frontend
Target version:
-
Start date:
2020-09-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The ScriptViewHelper adds the value of the src attribute to the AssetCollector.
Because of fluids default attribute escaping the value of the src attribute is already encoded while calling AssetCollector->addJavaScript().

The result is a wrong escaped src attribute in the frontend.

example:

input: https://typo3.org/foo.js?foo=bar&bar=baz
output: https://typo3.org/foo.js?foo=bar&amp;amp;bar=baz
expected: https://typo3.org/foo.js?foo=bar&amp;bar=baz


Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Bug #91742: Fluid view helper asset.script escape childrenResolved2020-07-03

Actions
Related to TYPO3 Core - Bug #92706: ScriptViewHelper and CssViewHelper access view helper arguments via TagBuilderClosed2020-10-26

Actions
Related to TYPO3 Core - Bug #92051: f:asset.script breaks ampersands and thus functionalityClosed2020-08-19

Actions
Actions #1

Updated by Gerrit Code Review over 3 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65700

Actions #2

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65700

Actions #3

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65700

Actions #4

Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65700

Actions #5

Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65700

Actions #6

Updated by Georg Ringer over 3 years ago

  • Related to Bug #91742: Fluid view helper asset.script escape children added
Actions #7

Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66294

Actions #8

Updated by Frank Nägler over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Helmut Hummel over 3 years ago

  • Related to Bug #92706: ScriptViewHelper and CssViewHelper access view helper arguments via TagBuilder added
Actions #10

Updated by Raphael Zschorsch over 3 years ago

  • Related to Bug #92051: f:asset.script breaks ampersands and thus functionality added
Actions #11

Updated by Benni Mack over 3 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF