Bug #92284
closed<f:asset.script> ViewHelper double escape the src attribute
100%
Description
The ScriptViewHelper adds the value of the src attribute to the AssetCollector.
Because of fluids default attribute escaping the value of the src attribute is already encoded while calling AssetCollector->addJavaScript().
The result is a wrong escaped src attribute in the frontend.
example:
input: https://typo3.org/foo.js?foo=bar&bar=baz
output: https://typo3.org/foo.js?foo=bar&amp;bar=baz
expected: https://typo3.org/foo.js?foo=bar&bar=baz
Updated by Gerrit Code Review over 3 years ago
- Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65700
Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65700
Updated by Gerrit Code Review over 3 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65700
Updated by Gerrit Code Review over 3 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65700
Updated by Gerrit Code Review over 3 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65700
Updated by Georg Ringer over 3 years ago
- Related to Bug #91742: Fluid view helper asset.script escape children added
Updated by Gerrit Code Review over 3 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66294
Updated by Frank Nägler over 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 7e979558e57846c6060717c400569f7fd2185b9f.
Updated by Helmut Hummel over 3 years ago
- Related to Bug #92706: ScriptViewHelper and CssViewHelper access view helper arguments via TagBuilder added
Updated by Raphael Zschorsch over 3 years ago
- Related to Bug #92051: f:asset.script breaks ampersands and thus functionality added