Bug #92284

<f:asset.script> ViewHelper double escape the src attribute

Added by Frank Naegler 11 days ago. Updated 10 days ago.

Status:
Under Review
Priority:
Should have
Assignee:
Category:
Frontend
Target version:
-
Start date:
2020-09-10
Due date:
% Done:

0%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The ScriptViewHelper adds the value of the src attribute to the AssetCollector.
Because of fluids default attribute escaping the value of the src attribute is already encoded while calling AssetCollector->addJavaScript().

The result is a wrong escaped src attribute in the frontend.

example:

input: https://typo3.org/foo.js?foo=bar&bar=baz
output: https://typo3.org/foo.js?foo=bar&amp;amp;bar=baz
expected: https://typo3.org/foo.js?foo=bar&amp;bar=baz

History

#1 Updated by Gerrit Code Review 11 days ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65700

#2 Updated by Gerrit Code Review 10 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65700

#3 Updated by Gerrit Code Review 10 days ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65700

#4 Updated by Gerrit Code Review 10 days ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65700

#5 Updated by Gerrit Code Review 10 days ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65700

Also available in: Atom PDF