Project

General

Profile

Actions

Task #92426

closed

Cleanup EXT:redirects

Added by Daniel Goerz over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2020-09-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The system extension redirects received two new features recently. The code should now be revisited and streamlined.

List of things to improve:

  • use singular for array command options
  • clarify option description
  • remove same purpose configuration class and extend demand instead
  • remove proxy method in service class
  • use demand as argument instead of property
  • filter order field against allow list
  • use dependency injection
  • cleanup superfluous annotations

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #102833: missing label in RedirectsCleanupCommand option statuscodeResolvedAnja Leichsenring2024-01-14

Actions
Actions #1

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65916

Actions #2

Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65916

Actions #3

Updated by Gerrit Code Review over 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65916

Actions #4

Updated by Gerrit Code Review over 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65916

Actions #5

Updated by Gerrit Code Review over 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65916

Actions #6

Updated by Helmut Hummel over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack over 3 years ago

  • Status changed from Resolved to Closed
Actions #8

Updated by Anja Leichsenring 3 months ago

  • Related to Bug #102833: missing label in RedirectsCleanupCommand option statuscode added
Actions

Also available in: Atom PDF