Bug #93549: DataHandler unusable in CLI (Symfony) mode because FlashMessages using session data - TYPO3 Core - TYPO3 Forge

Custom queries

12 LTS
Accessibility
Dashboard issues
Easy tasks
Extbase Issues
FAL Issues
FAL Sprint 2023
Hierarchical Issues
Issues reported for v11
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
Most wanted Bugfixes
Most wanted Features
My open issues
New & Unassigned
No feedback within 90 days
Open Bugs
Open issues of 10
Page Tree Regressions after 2020-07-28
Recently modified
Regressions
Stabilization Issues
Usability or UX

Watchers (3)

Benni Mack
Christian Weiske
Markus Klein

Actions

Copy link

Bug #93549

closed

DataHandler unusable in CLI (Symfony) mode because FlashMessages using session data

Added by Stefan P about 3 years ago. Updated over 2 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

DataHandler aka TCEmain

Target version:

Start date:

2021-02-19

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Using the DataHandler in CLI mode does not reliably work because on some validation errors it generates FlashMessages with $storeInSession = true, an example being checkValue_input_ValidateEmail() (called by 'eval' => 'email' ). The CLI has no session, even when \TYPO3\CMS\Core\Core\Bootstrap::initializeBackendAuthentication(); was called.

So the DataHandler in CLI only works if the input data is fully pre-sanitized, defeating the main purpose of using the DataHandler at all.

Discovered in v9, probably valid for v10+ as well.

Updated by Stefan P about 3 years ago

Related to Bug #86877: refindex:update does not work in CLI-Context added

Actions

Copy link

Updated by Stefan P about 3 years ago

The exception then thrown is this:

Uncaught TYPO3 Exception Argument 1 passed to TYPO3\CMS\Core\Session\Backend\DatabaseSessionBackend::update() must be of the type string, null given, called in /typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php on line 1323

Actions

Copy link

Updated by Christian Weiske about 3 years ago

We hook into DataHandler to do geocoding of addresses when records are saved. Errors and success information are shown via flash messages.

Doing the same in batch mode from CLI is broken with TYPO3 v9 because of this problem here.
Our CLI script manually prints the queued flash messages to stdout.

Actions

Copy link

Updated by Gerrit Code Review about 3 years ago

Status changed from New to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68178

Actions

Copy link

Updated by Christian Weiske about 3 years ago

The patch works for v10 as well.

In v11, everything is different and the patch does not apply anymore.

Actions

Copy link

Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68921

Actions

Copy link

Updated by Benni Mack about 3 years ago

Can you check my approach (which should work for master)?

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68921

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68921

Actions

Copy link

#10

Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68921

Actions

Copy link

#11

Updated by Benni Mack almost 3 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset e190d9f87c9d140429b35afea6b067ad24decf3f.

Actions

Copy link

#12

Updated by Gerrit Code Review almost 3 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69052

Actions

Copy link

#13

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69052

Actions

Copy link

#14