TYPO3 Core

Within method public function initializeChangePasswordAction(), this has no effect, it goes on with the same original request:

        if ($originalResult->hasErrors()) {
            return (new ForwardResponse('showChangePassword'))
                ->withControllerName('PasswordRecovery')
                ->withExtensionName('felogin')
                ->withArguments(['hash' => $this->request->getArgument('hash')]);
        }

This seems to stem from returning a PSR7 response in an initialisation where a void is actually expected (BTW the whole patch changed the method signature to return PSR7 response but without adapting the PHP comment to show that it returns something).

Problem: when using the previous ->forward() method, a StopActionException was thrown, now this is not the case anymore, a response is returned but not used at all, and the flow continues silently to the original request.

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68720

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69677

I pushed a new, alternative patch for this issue. From my point of view, the PasswordRecoveryController has some areas for improvement, since the process of validating the hash parameter or the new password is not really implemented "the Extbase way" and should be refactored as validators to get rid of manually adding errors to the Extbase request.

I also think, that initialize*Actions should not be able to handle a possible response object, since checks and forwards can be implemented in the controller action, which in v11 expects a PSR-7 response to be returned.

The new patch fixes the broken behaviour introduces in #92815 and can be the first of a series of patches to improve PasswordRecoveryController.

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69677

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69677

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69677

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69677

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69677

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69677