Bug #94714
closed
SvgFilesSanitization prevent subsequent file search
100%
Description
The method SvgFilesSanitization::resolveSvgFiles set up a file extension filter in every resource storage. However, it does not reset the filter after use.
It prevents the usage of FormPersistenceManager::listForms to retrieve the forms to check them in some own update wizard. Or any other file searching which expect the filters to be defaulted.
A trivial fix would be in svgfilessanitization.patch.
Another solution would be to update FormPersistenceManager to replace the filters instead of adding, in formpersistencemanager.patch.
Or maybe do both?
Introduced since #94492
Files
Updated by Pierrick Caillon over 2 years ago
- Related to Task #94492: Introduce t3g/svg-sanitizer added
Updated by Oliver Hader over 2 years ago
- Status changed from New to Needs Feedback
Thx for the report. Can you please give a short step-by-step example on how to trigger/reproduce the misbehavior? Thx!
Updated by Pierrick Caillon over 2 years ago
- File SomeFormWizard.php SomeFormWizard.php added
Attached in SomeFormWizard.php, a bare upgrade wizard to reproduce. The wizard must be registered as defined in documentation
You should have typo3/cms-form installed and active, and have at least one form definition in your instance.
The wizard will show up when there is a form in the instance.
The SvgFilesSanitization wizard must not have been run, or there is no SVG in your resource storages for it to be run before.
Updated by Oliver Hader over 2 years ago
- Status changed from Needs Feedback to Accepted
Thanks for the feedback & I see...\TYPO3\CMS\Core\Resource\StorageRepository::$storageInstances actually leads to Storage objects being handled like singletons - which shows the software design flaw, since (individual) filters should be separated from (more or less) static file-storage models.
Updated by Gerrit Code Review over 2 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70211
Updated by Oliver Hader over 2 years ago
@Pierrick, I've create a change request at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70211, referring to you as author since you provided the patch files.
Updated by Gerrit Code Review over 2 years ago
Patch set 1 for branch 11.3 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70295
Updated by Gerrit Code Review over 2 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70296
Updated by Gerrit Code Review over 2 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70297
Updated by Pierrick Caillon over 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset ddba21633433273e936d5760577a87aaed10a6e0.
Updated by