Bug #94714
closed
SvgFilesSanitization prevent subsequent file search
Added by Pierrick Caillon about 3 years ago.
Updated almost 3 years ago.
Description
The method SvgFilesSanitization::resolveSvgFiles
set up a file extension filter in every resource storage. However, it does not reset the filter after use.
It prevents the usage of FormPersistenceManager::listForms
to retrieve the forms to check them in some own update wizard. Or any other file searching which expect the filters to be defaulted.
A trivial fix would be in svgfilessanitization.patch.
Another solution would be to update FormPersistenceManager
to replace the filters instead of adding, in formpersistencemanager.patch.
Or maybe do both?
Introduced since #94492
Files
- Related to Task #94492: Introduce t3g/svg-sanitizer added
- TYPO3 Version changed from 10 to 9
- Status changed from New to Needs Feedback
Thx for the report. Can you please give a short step-by-step example on how to trigger/reproduce the misbehavior? Thx!
Attached in SomeFormWizard.php, a bare upgrade wizard to reproduce. The wizard must be registered as defined in documentation
You should have typo3/cms-form
installed and active, and have at least one form definition in your instance.
The wizard will show up when there is a form in the instance.
The SvgFilesSanitization wizard must not have been run, or there is no SVG in your resource storages for it to be run before.
- Description updated (diff)
- Status changed from Needs Feedback to Accepted
Thanks for the feedback & I see...
\TYPO3\CMS\Core\Resource\StorageRepository::$storageInstances
actually leads to Storage
objects being handled like singletons - which shows the software design flaw, since (individual) filters should be separated from (more or less) static file-storage models.
- Status changed from Accepted to Under Review
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
- Status changed from Resolved to Closed
Also available in: Atom
PDF