FlexForm – String returned for empty sections instead of Array
When using the section feature of FlexForm, and empting a section, the result parsed flexform will contain an empty string instead of an empty array.
This behaviour existed before the introduction of FlexFormService.
To reproduce, a contributor must remove all elements in a flexform section and save. The flexform will then contain:
<field index="my_field"> <el index="el"></el> </field>
In EXT:core/Classes/Service/FlexFormService.phpL49, when discovering a node named
el, the parser is recursively called. When
$nodeValue is an empty string, it should return an empty array. Not doing so force developers to test again empty, which can not always be done straightforwardly. It is expected to be able to test with
I attached an example flexform to test with.
Updated by Larry Garfield over 1 year ago
- Status changed from New to Needs Feedback
Hi Pierrick. I'm trying to turn your examples into a test so I can make a patch for this, but I'm not entirely clear on it. There's no empty section in the XML you provided, is there?
When I run it through a test (after adding a "data" element wrapper around "sheets", and adding index attributes to sheets and sDEF to avoid parse errors), I get the same result back both with and without your patch.
Can you clarify, perhaps with a confirmed test case?
(I'm testing on `main` currently, so the future v12.)
Updated by Pierrick Caillon over 1 year ago
- File unexpected result after changes.mp4 unexpected result after changes.mp4 added
- File temp.zip temp.zip added
I have created the smallest possible extension to provide necessary configuration.
In the attached video, I illustrate the reproduction steps using this extension.
Should I also illustrate transformation service in frontend?
(Reproduction done using main (e97def2559e6185392d2f3089c51ced2e740327a))