Project

General

Profile

Actions

Task #95298

closed

ViewHelpers will be declared final in v12

Added by Christian Kuhn almost 3 years ago. Updated 9 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2021-09-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues 5 (2 open3 closed)

Related to TYPO3 Core - Task #96362: Avoid extending ImageViewHelperClosed2021-12-15

Actions
Related to TYPO3 Core - Task #96368: Declare all ViewHelpers finalClosed2021-12-16

Actions
Related to TYPO3 Core - Bug #101927: TYPO3 Fluid Core ViewHelpers should not be declared "final class"Rejected2023-09-15

Actions
Related to TYPO3 Core - Bug #101929: ViewHelperInvoker should catch Exceptions allow the Site-Developer to handle or supress exceptionsNew2023-09-15

Actions
Related to TYPO3 Core - Bug #101928: f:image(.uri) and other FAL/File ViewHelpers should never raise an Exception for missing files!Needs Feedback2023-09-15

Actions
Actions #1

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71164

Actions #2

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71164

Actions #3

Updated by Christian Kuhn almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed
Actions #5

Updated by Christian Kuhn over 2 years ago

  • Related to Task #96362: Avoid extending ImageViewHelper added
Actions #6

Updated by Christian Kuhn over 2 years ago

  • Related to Task #96368: Declare all ViewHelpers final added
Actions #7

Updated by Georg Ringer 9 months ago

  • Related to Bug #101927: TYPO3 Fluid Core ViewHelpers should not be declared "final class" added
Actions #8

Updated by Gabriel Kaufmann / Typoworx NewMedia 9 months ago

I think we need to discuss about that. I could agree with the plan to use "final class", but then at least the logic inside the ViewHelpers should be available for developers by either AbstractClass or even better by implementing it into a Trait.

This way the core-classes could use "final class", but developers also can reuse the core-code doing slight modifications (f.e. catching FAL-Exceptions for f:image) and implementing a more smooth handling of such problems.

Related:
#101927
#101928

Actions #9

Updated by Gabriel Kaufmann / Typoworx NewMedia 9 months ago

  • Related to Bug #101929: ViewHelperInvoker should catch Exceptions allow the Site-Developer to handle or supress exceptions added
Actions #10

Updated by Oliver Hader 9 months ago

  • Related to Bug #101928: f:image(.uri) and other FAL/File ViewHelpers should never raise an Exception for missing files! added
Actions

Also available in: Atom PDF