Task #95298: ViewHelpers will be declared final in v12 - TYPO3 Core - TYPO3 Forge

Custom queries

12 LTS
Accessibility
Dashboard issues
Easy tasks
Extbase Issues
FAL Issues
FAL Sprint 2023
Hierarchical Issues
Issues reported for v11
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
Most wanted Bugfixes
Most wanted Features
My open issues
New & Unassigned
No feedback within 90 days
Open Bugs
Open issues of 10
Page Tree Regressions after 2020-07-28
Recently modified
Regressions
Stabilization Issues
Usability or UX

Watchers (1)

Georg Ringer

Actions

Copy link

Task #95298

closed

ViewHelpers will be declared final in v12

Added by Christian Kuhn over 2 years ago. Updated 8 months ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Target version:

Start date:

2021-09-21

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Sprint Focus:

Related issues 5 (2 open — 3 closed)

Related to TYPO3 Core - Task #96362: Avoid extending ImageViewHelper

Closed

2021-12-15

Actions

Related to TYPO3 Core - Task #96368: Declare all ViewHelpers final

Closed

2021-12-16

Actions

Related to TYPO3 Core - Bug #101927: TYPO3 Fluid Core ViewHelpers should not be declared "final class"

Rejected

2023-09-15

Actions

Related to TYPO3 Core - Bug #101929: ViewHelperInvoker should catch Exceptions allow the Site-Developer to handle or supress exceptions

New

2023-09-15

Actions

Related to TYPO3 Core - Bug #101928: f:image(.uri) and other FAL/File ViewHelpers should never raise an Exception for missing files!

Needs Feedback

2023-09-15

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71164

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71164

Actions

Copy link

Updated by Christian Kuhn over 2 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset a8a87287cefeca40a39003dbb0219d634bf9665c.

Actions

Copy link

Updated by Benni Mack over 2 years ago

Status changed from Resolved to Closed

Actions

Copy link

Updated by Christian Kuhn over 2 years ago

Related to Task #96362: Avoid extending ImageViewHelper added

Actions

Copy link

Updated by Christian Kuhn over 2 years ago

Related to Task #96368: Declare all ViewHelpers final added

Actions

Copy link

Updated by Georg Ringer 8 months ago

Related to Bug #101927: TYPO3 Fluid Core ViewHelpers should not be declared "final class" added

Actions

Copy link

Updated by Gabriel Kaufmann / Typoworx NewMedia 8 months ago

I think we need to discuss about that. I could agree with the plan to use "final class", but then at least the logic inside the ViewHelpers should be available for developers by either AbstractClass or even better by implementing it into a Trait.

This way the core-classes could use "final class", but developers also can reuse the core-code doing slight modifications (f.e. catching FAL-Exceptions for f:image) and implementing a more smooth handling of such problems.

Related:
#101927
#101928

Actions

Copy link