Bug #96009: inputType=inputLink not working anymore in IRRE - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #96009

closed

inputType=inputLink not working anymore in IRRE

Added by Chris Müller over 2 years ago. Updated over 1 year ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Backend User Interface

Target version:

Start date:

2021-11-17

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

7.4

Tags:

Complexity:

Is Regression:

Yes

Sprint Focus:

Description

Since TYPO3 v11.5.3 the link selection modal does not work anymore for a field in IRRE with type="input" and inputType="inputLink".

- When clicking on the link button, the modal is opened with activated overlay, so nothing can be done. Only a reload of the backend helps then.
- A click on the "Toggle link explanation" button does nothing.

In both cases no JavaScript error occurs in the console. With TYPO3 v11.5.2 everything worked as expected.

My TCA:

'link' => [
        'exclude' => true,
        'label' => 'Link',
        'config' => [
            'type' => 'input',
            'renderType' => 'inputLink',
            'size' => 50,
            'max' => 1024,
            'eval' => 'trim,required',
            'fieldControl' => [
                'linkPopup' => [
                    'options' => [
                        'title' => 'LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:header_link_formlabel',
                        'blindLinkOptions' => 'file,folder,telephone,mail',
                    ],
                ],
            ],
            'softref' => 'typolink',
        ],
    ],

Files

Screen Shot 2021-11-17 at 18.08.09.png (727 KB) Screen Shot 2021-11-17 at 18.08.09.png

Oliver Hader, 2021-11-17 17:08

Related issues 7 (0 open — 7 closed)

Related to TYPO3 Core - Task #95954: Reduce inline JavaScript in FormEngine AJAX responses

Closed

Oliver Hader

2021-11-10

Actions

Related to TYPO3 Core - Bug #96027: FlexForm: Typolink link browser/wizard doesn not open in popup

Closed

2021-11-18

Actions

Has duplicate TYPO3 Core - Bug #95998: Can't add a link on an image with link browser

Closed

2021-11-16

Actions

Has duplicate TYPO3 Core - Bug #96085: LINK Browser in Inline Records for fields with renderType "inputLink" no longer works correctly.

Closed

2021-11-26

Actions

Has duplicate TYPO3 Core - Bug #96088: Linkwizard in IRRE element appears behind overlay

Closed

2021-11-26

Actions

Has duplicate TYPO3 Core - Bug #96175: Link Wizard modal conflict at inline records

Closed

2021-12-01

Actions

Has duplicate TYPO3 Core - Bug #96090: Broken LinkWizard for new FileReference

Closed

2021-11-26

Actions

Copy link

Updated by Oliver Hader over 2 years ago

Maybe related to https://review.typo3.org/c/Packages/TYPO3.CMS/+/72154
Can you please post the JSON that is returned when adding a new inline element?

Actions

Copy link

Updated by Chris Müller over 2 years ago

Here it is:

ajax[context]: {"config":"{\"type\":\"inline\",\"allowed\":\"tx_myext_button\",\"foreign_table\":\"tx_myext_button\",\"foreign_sortby\":\"sorting\",\"foreign_field\":\"parent\",\"foreign_table_field\":\"parenttable\",\"size\":5,\"minitems\":0,\"maxitems\":5,\"appearance\":{\"collapseAll\":true,\"expandSingle\":true,\"levelLinksPosition\":\"bottom\",\"useSortable\":true,\"showPossibleLocalizationRecords\":true,\"showSynchronizationLink\":true,\"enabledControls\":{\"info\":false,\"new\":true,\"dragdrop\":true,\"sort\":true,\"hide\":true,\"delete\":true,\"localize\":true}},\"inline\":{\"parentSysLanguageUid\":0,\"first\":2355,\"last\":2355},\"originalReturnUrl\":\"\\/typo3\\/record\\/edit?token=4773b188d7295b56ff85a2b43f104d7fef4ccd0f&edit%5Bpages%5D%5B15%5D=edit&returnUrl=%2Ftypo3%2Fmodule%2Fweb%2Flayout%3Ftoken%3D7c4b5644516381421704c60efed394f610a6b83c%26id%3D15&route=%2Frecord%2Fedit\"}","hmac":"de2e5ed2b4cf4212378099d748c4173709e39893"}

Actions

Copy link

Updated by Oliver Hader over 2 years ago

Thx. Bisected that to 08669c3fbfb6b042e02d1ba432c6e86d4d2aba2d of issue #95954

Actions

Copy link

Updated by Oliver Hader over 2 years ago

Related to Task #95954: Reduce inline JavaScript in FormEngine AJAX responses added

Actions

Copy link

Updated by Oliver Hader over 2 years ago

Subject changed from Regression: inputType=inputLink not working anymore in IRRE to inputType=inputLink not working anymore in IRRE
Status changed from New to Accepted

Actions

Copy link

Updated by Oliver Hader over 2 years ago

File Screen Shot 2021-11-17 at 18.08.09.png Screen Shot 2021-11-17 at 18.08.09.png added

Another way to test/reproduce:

create new content element of "text with images" (or "images")
add new image in corresponding tab
click link icon in that new file reference inline element
find modal overlay to being removed on initialization (see screenshot)

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72214

Actions

Copy link

Updated by Oliver Hader over 2 years ago

Okay, that was a stupid thing... after refactoring the mentioned change, RequireJS modules for corresponding form fields were initialized twice - which lead to side-effects loading the Modal dialog. This show, that FormEngine.js et al are not resilient enough against those API calls...

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72214

Actions

Copy link

#10