Project

General

Profile

Actions
Copy link

Bug #96209

closed

Importing TER extension list fails

Added by Oliver Hader almost 3 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extension Manager
Target version:
-
Start date:
2021-12-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

(test in current main branch)

SQL error message: Data too long for column 'version' at row 13

Caused by (references)

Files

Download all files
exception.html (58.6 KB) exception.html Oliver Hader, 2021-12-02 20:35
Screen Shot 2021-12-02 at 21.30.42.png (588 KB) Screen Shot 2021-12-02 at 21.30.42.png Oliver Hader, 2021-12-02 20:35
Actions
Copy link
 #2

Updated by Oliver Bartsch almost 3 years ago

Seems like this is caused by the latest EXT:solr version 11.5.0-pre-alpha-1.

Actions
Copy link
 #3

Updated by Benni Mack almost 3 years ago

I think the solution here is to disallow alpha/beta versions on upload to TER and to remove the affected versions from the extensions.xml.gz

Actions
Copy link
 #4

Updated by Oliver Hader almost 3 years ago

Corresponding database field tx_extensionmanager_domain_model_extension.version is declared as version varchar(15) NOT NULL default '',.

              |          # current limit
123456789012345678901234 # ruler

11.5.0-pre-alpha-1
11.5.0
11.5.0-alpha1
11.5.999
11.5.999-alpha1
999.999.999-alpha1
999.999.999-alpha999

123456789012345678901234 # ruler
              |          # current limit

TER upload should allow only the following:

  • 11.5.0
  • 11.5.0-alpha1
  • 11.5.0-beta1
  • 11.5.0-rc1

Besides that, it probably might makes sense to extend version for future versions to allow 20-24 chars

Actions
Copy link
 #5

Updated by Oliver Hader almost 3 years ago

  • Description updated (diff)
Actions
Copy link
 #6

Updated by Oliver Hader almost 3 years ago

  • Status changed from New to Accepted
Actions
Copy link
 #7

Updated by Thomas Löffler almost 3 years ago

Same issue here with https://extensions.typo3.org/extension/templavoilaplus.

A short look to the TER code gave me no hint why these versions could be uploaded.
We have a strict regex for version numbers which is used on every upload.
Will take a deeper look today.

Actions
Copy link
 #8

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72477

Actions
Copy link
 #10

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72477

Actions
Copy link
 #11

Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72477

Actions
Copy link
 #12

Updated by Gerrit Code Review almost 3 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72422

Actions
Copy link
 #13

Updated by Oliver Bartsch almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #14

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72484

Actions
Copy link
 #15

Updated by Oliver Bartsch almost 3 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #16

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF