Project

General

Profile

Actions
Copy link

Bug #98118

closed

Social images are not cropped anymore to their expected ratio

Added by Sascha Egerer over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Kevin Appelt
Category:
SEO
Target version:
next-patchlevel
Start date:
2022-08-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

Before #97248 images have been cropped to 1.91:1 ratio. This is not the case anymore. Images do now have a totally wrong ratio if the original file is not in the expected ratio.

So before this change an image with 200x200 has been cropped to 200x104. Now it is just rendered as 200x200.
The same if the image is 2000x800. Before this change it was cropped to 1522x800 and now it's just rendered as 2000x800

What have I done

  • Login and edit a page property
  • Add an Image with a 200x200 resolution to "Social Media" Tab as OpenGraph Image or Twitter Card Image
  • Save page properties
  • Load Frontend View

What I expected

  • the image is added to the og:image and og:image:url tag
  • ratio of that image is 1.91:1
  • Image is cropped to 200x104 resolution
  • Image Path contains compressed folder

What happened

  • Image Resolution is still 200x200
  • Image ratio is 1:1
  • Filepath is path to original file

Acceptance Test

  • Use one of Example files as Open Graph Image or Twitter Card Image in page properties
  • Original file 200x200 cropped to 200x104
  • Original file 2000x800 cropped to 1522x800
  • og:image and og:image:url tag contains something like "../fileadmin/_processed_/.." in file path

Files

Download all files
og_image_1200x630.jpg (54.2 KB) og_image_1200x630.jpg Kevin Appelt, 2022-08-12 07:32
og_image_200x200.jpg (13 KB) og_image_200x200.jpg Kevin Appelt, 2022-08-12 07:32
og_image_2000x800.jpg (86.5 KB) og_image_2000x800.jpg Kevin Appelt, 2022-08-12 07:32
og_image_2400x1260.jpg (146 KB) og_image_2400x1260.jpg Kevin Appelt, 2022-08-12 07:32

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Bug #97248: social images are slightly cropped in EXT:seoClosedKevin Appelt2022-03-28

Actions
Actions
Copy link
 #1

Updated by Sascha Egerer over 2 years ago

  • Related to Bug #97248: social images are slightly cropped in EXT:seo added
Actions
Copy link
 #2

Updated by Sascha Egerer over 2 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Oliver Hader over 2 years ago

  • Is Regression set to Yes
Actions
Copy link
 #4

Updated by Kevin Appelt over 2 years ago

  • Category set to SEO
  • Assignee set to Kevin Appelt
  • Target version set to next-patchlevel

I am investigating the behaviour.

Actions
Copy link Download all files
 #5

Updated by Kevin Appelt over 2 years ago

I can confirm the issue. A patch will follow shortly.

If anyone wants to review the behaviour, I have attached test files (Taken from https://unsplash.com/photos/DtDlVpy-vvQ).

Actions
Copy link
 #6

Updated by Gerrit Code Review over 2 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422

Actions
Copy link
 #7

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422

Actions
Copy link
 #8

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422

Actions
Copy link
 #9

Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422

Actions
Copy link
 #10

Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422

Actions
Copy link
 #11

Updated by Gerrit Code Review over 2 years ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422

Actions
Copy link
 #12

Updated by Gerrit Code Review over 2 years ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422

Actions
Copy link
 #13

Updated by Annett Jähnichen over 2 years ago

  • Description updated (diff)
Actions
Copy link
 #14

Updated by Annett Jähnichen over 2 years ago

I can reproduce behavior in main Branch and TYPO3 11.5.14.

For both tested the patch and the acceptance test was fulfilled.

Actions
Copy link
 #15

Updated by Gerrit Code Review over 2 years ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422

Actions
Copy link
 #16

Updated by Gerrit Code Review about 2 years ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422

Actions
Copy link
 #17

Updated by Gerrit Code Review about 2 years ago

Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422

Actions
Copy link
 #18

Updated by Gerrit Code Review about 2 years ago

Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422

Actions
Copy link
 #19

Updated by Gerrit Code Review about 2 years ago

Patch set 12 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422

Actions
Copy link
 #20

Updated by Gerrit Code Review about 2 years ago

Patch set 13 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422

Actions
Copy link
 #21

Updated by Gerrit Code Review about 2 years ago

Patch set 14 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422

Actions
Copy link
 #22

Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75531

Actions
Copy link
 #23

Updated by Kevin Appelt about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #24

Updated by Gerrit Code Review about 2 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75531

Actions
Copy link
 #25

Updated by Kevin Appelt about 2 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #26

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF