Bug #98118
closed
Social images are not cropped anymore to their expected ratio
100%
Description
Before #97248 images have been cropped to 1.91:1 ratio. This is not the case anymore. Images do now have a totally wrong ratio if the original file is not in the expected ratio.
So before this change an image with 200x200 has been cropped to 200x104. Now it is just rendered as 200x200.
The same if the image is 2000x800. Before this change it was cropped to 1522x800 and now it's just rendered as 2000x800
What have I done¶
- Login and edit a page property
- Add an Image with a 200x200 resolution to "Social Media" Tab as OpenGraph Image or Twitter Card Image
- Save page properties
- Load Frontend View
What I expected¶
- the image is added to the og:image and og:image:url tag
- ratio of that image is 1.91:1
- Image is cropped to 200x104 resolution
- Image Path contains compressed folder
What happened¶
- Image Resolution is still 200x200
- Image ratio is 1:1
- Filepath is path to original file
Acceptance Test¶
- Use one of Example files as Open Graph Image or Twitter Card Image in page properties
- Original file 200x200 cropped to 200x104
- Original file 2000x800 cropped to 1522x800
- og:image and og:image:url tag contains something like "../fileadmin/_processed_/.." in file path
Files
Updated by Sascha Egerer over 1 year ago
- Related to Bug #97248: social images are slightly cropped in EXT:seo added
Updated by
Updated by Kevin Appelt over 1 year ago
- Category set to SEO
- Assignee set to Kevin Appelt
- Target version set to next-patchlevel
I am investigating the behaviour.
Updated by Kevin Appelt over 1 year ago
- File og_image_200x200.jpg og_image_200x200.jpg added
- File og_image_1200x630.jpg og_image_1200x630.jpg added
- File og_image_2000x800.jpg og_image_2000x800.jpg added
- File og_image_2400x1260.jpg og_image_2400x1260.jpg added
- Status changed from New to In Progress
I can confirm the issue. A patch will follow shortly.
If anyone wants to review the behaviour, I have attached test files (Taken from https://unsplash.com/photos/DtDlVpy-vvQ).
Updated by Gerrit Code Review over 1 year ago
- Status changed from In Progress to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422
Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422
Updated by Gerrit Code Review over 1 year ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422
Updated by Gerrit Code Review over 1 year ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422
Updated by Gerrit Code Review over 1 year ago
Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422
Updated by Gerrit Code Review over 1 year ago
Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422
Updated by Gerrit Code Review over 1 year ago
Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422
Updated by Annett Jähnichen over 1 year ago
I can reproduce behavior in main Branch and TYPO3 11.5.14.
For both tested the patch and the acceptance test was fulfilled.
Updated by Gerrit Code Review over 1 year ago
Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422
Updated by Gerrit Code Review over 1 year ago
Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422
Updated by Gerrit Code Review over 1 year ago
Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422
Updated by Gerrit Code Review over 1 year ago
Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422
Updated by Gerrit Code Review over 1 year ago
Patch set 12 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422
Updated by Gerrit Code Review over 1 year ago
Patch set 13 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422
Updated by Gerrit Code Review over 1 year ago
Patch set 14 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422
Updated by Gerrit Code Review over 1 year ago
Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75531
Updated by Kevin Appelt over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b789f5a39603593d675a253714a26089762617c4.
Updated by Gerrit Code Review over 1 year ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75531
Updated by Kevin Appelt over 1 year ago
- Status changed from Under Review to Resolved
Applied in changeset fa7bd9f9802939d31c6b5a9d121b31b0dd84ad4d.
Updated by 
