Feature #99510
openScriptViewHelper and CssViewHelper miss file to inline rendering option
0%
Description
f:asset.css and f:asset.script are great but miss an option to render inline from files.
This would help keeping JavaScript and CSS out of XML files in case one desires rendering it inline.
So for example this CSS file would be loaded inline:
<f:asset.css identifier="extensionName" inline href="EXT:extensionname/Resources/Public/Css/extensionname.css" />
Probably not so simple but...
Registering the 'inline' attribute and then adding a condition something like this in:
typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php
if ($file !== null) {
if ($inline) {
$content = (string)file_get_contents(GeneralUtility::getFileAbsFileName(trim($file)));
$this->assetCollector->addInlineStyleSheet($identifier, $content, $attributes, $options);
} else {
$this->assetCollector->addStyleSheet($identifier, $file, $attributes, $options);
}
}
Updated by Tanel Põld over 1 year ago
Semantically 'embed' or 'internal' instead of 'inline' would be more correct...
Updated by Benni Mack about 1 year ago
- Target version changed from 12 LTS to Candidate for Major Version
Updated by Gerrit Code Review about 1 month ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84424
Updated by Gerrit Code Review about 1 month ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84424
Updated by Gerrit Code Review about 1 month ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84424
Updated by Gerrit Code Review about 1 month ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84424
Updated by Gerrit Code Review about 1 month ago
Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84424