Project

General

Profile

Actions

Bug #99734

closed

Extbase UriBuilder->setRequest() is internal but recommended to use

Added by Chris Müller almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extbase
Target version:
Start date:
2023-01-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

With change https://review.typo3.org/c/Packages/TYPO3.CMS/+/77507 the Extbase UriBuilder has a method "setRequest()" which is internal. However, the changelog states in the migration section that it should be used outside a controller to pass the current request object.


Files


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Task #99650: use local request object in UriBuilderClosedAnja Leichsenring2023-01-19

Actions
Related to TYPO3 Core - Bug #99770: Build extbase attribute in UriBuilder fallbackClosed2023-01-31

Actions
Actions #1

Updated by Chris Müller almost 2 years ago

  • Related to Task #99650: use local request object in UriBuilder added
Actions #2

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77630

Actions #3

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77630

Actions #4

Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77630

Actions #5

Updated by Benni Mack almost 2 years ago

We have similar problem with that change: Type problem now. See screenshot attached.

Actions #6

Updated by Chris Müller almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Christian Kuhn almost 2 years ago

  • Related to Bug #99770: Build extbase attribute in UriBuilder fallback added
Actions #8

Updated by Benni Mack almost 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF