Project

General

Profile

Actions

Bug #100901

open

Missing custom CSS in NewContentElementWizard

Added by Nikita Hovratov over 1 year ago. Updated 4 months ago.

Status:
Accepted
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2023-05-19
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:
Stabilization Sprint

Description

Since the new web component based NewContentElementWizard custom included CSS via TBE_STYLES is not included anymore.
This leads to broken preview icons, if a custom IconProvider was used. E.g. Mask uses FontAwesome Icons, but the CSS is not included from
$GLOBALS['TBE_STYLES']['skins']['fontawesome_provider']['stylesheetDirectories']['css'] = 'EXT:fontawesome_provider/Resources/Public/Css/';

The backend.css file seems to be hard-coded:

Build/Sources/TypeScript/backend/new-content-element-wizard.ts:343

    // Load shared css file
    const link = document.createElement('link');
    link.setAttribute('rel', 'stylesheet');
    link.setAttribute('href', TYPO3.settings.cssUrls.backend);
    this.shadowRoot.appendChild(link);

typo3/sysext/core/Classes/Page/PageRenderer.php:2244

    protected function addGlobalCSSUrlsToInlineSettings()
    {
        $this->inlineSettings['cssUrls'] = [
            'backend' => $this->getStreamlinedFileName('EXT:backend/Resources/Public/Css/backend.css'),
        ];
    }


Files

mask-fa-icon.png (21 KB) mask-fa-icon.png Nikita Hovratov, 2023-05-20 17:02
Actions #1

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79093

Actions #2

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79093

Actions #3

Updated by Nikita Hovratov over 1 year ago

Actions #4

Updated by Benni Mack over 1 year ago

  • Sprint Focus set to Stabilization Sprint
Actions #5

Updated by Urs Braem 12 months ago

The font custom icons for mask elements are very important to make the new content element wizard user friendly. This bug will break that for upgrades and make creating new icons more tedious.

Maybe we can sponsor the fix?

Actions #6

Updated by Markus Klein 4 months ago

  • Status changed from Under Review to Accepted
Actions

Also available in: Atom PDF