Project

General

Profile

Actions

Bug #102021

open

Provide better documentation for ChangeLog 95222

Added by Stefan Froemken 9 months ago. Updated 2 days ago.

Status:
Needs Feedback
Priority:
Should have
Assignee:
-
Category:
Documentation
Target version:
Start date:
2023-09-23
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
11
PHP Version:
7.4
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

Hello,

I have a problem understanding that change:

https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.5/Deprecation-95222-ExtbaseViewInterface.html

Quote:

method initializeView() which was never actively used, calling that method will vanish in TYPO3 v12

But some lines later you can read:

that empty method will be removed in TYPO3 v12, but will still be called if it exists in classes extending ActionController

There can only be one truth. Since initializeView is still called in TYPO3 12 and TYPO3 13-dev, the last quote is correct. So the first quote has to be rewritten a bit.

I spent almost an hour trying to understand this change:
It seems that the call to ActionController::initializeView has been removed from the processRequest method and it should be avoided to call parent::initializeView in extension controllers.
However, as there is still a check for an existing initializeView in the processRequest method, extension developers can still use this method name to call in their own extension controllers.

Stefan

Actions #1

Updated by Stefan Froemken 9 months ago

Oh dear.

Yes, there was an initializeView method in Extbase ViewInterface (TYPO3 11) and a lot of other related views had implemented that "useless" method with empty body. So, deprecating ViewInterface and removing the call to ViewInterface::initializeView in resolveView() of ActionController was a good decision.

BUT:
We also had an initializeView() method directly in extbase ActionController which was removed with this patch:

https://review.typo3.org/c/Packages/TYPO3.CMS/+/72436

The patch from above has also attached further migration steps to the documentation of the deprecated ViewInterface:

https://review.typo3.org/c/Packages/TYPO3.CMS/+/71089

IMO that's not right. Both patches needs their own ChangeLog files.
1.) Removing the call to initializeView of ViewInterface from Extbase ActionController and marking ViewInterface as deprecated
2.) Removing the initializeView method from ActionController.

Stefan

Actions #2

Updated by Garvin Hicking 2 days ago

  • Status changed from New to Needs Feedback

Would you maybe be interested in providing a patch for this? I could help in reviewing and phrasing... :-)

Actions

Also available in: Atom PDF