Project

General

Profile

Actions
Copy link

Task #102978

open

EXT:form Improvement: Do not render pencil Icons for forms that are not editable

Added by Daniel Goerz 10 months ago. Updated about 1 month ago.

Status:
Under Review
Priority:
Could have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2024-01-29
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:

Description

In the backend module "Forms", editable and uneditable forms both have a pencil icon rendered in the action button. For uneditable forms the button is a disabled with the pencil beeing mildly opaque. This is very hard to see:

So for locked forms, that are not editable, we should use a different icon instead. For example the lock icon.

Files

Download all files
Screenshot 2024-01-29 at 13.02.50.png (6.13 KB) Screenshot 2024-01-29 at 13.02.50.png Daniel Goerz, 2024-01-29 12:03
form-lock-icon.png (71.8 KB) form-lock-icon.png Georg Ringer, 2024-05-25 16:47

Related issues 4 (2 open — 2 closed)

Related to TYPO3 Core - Feature #102979: EXT:form Improvement: Make list of forms filterableClosed2024-01-29

Actions
Related to TYPO3 Core - Feature #102865: Add PSR-14 Event to modify loaded form definitionClosedOliver Bartsch2024-01-18

Actions
Related to TYPO3 Core - Feature #103266: EXT:form Improvement: Introduce Possibility for Validators at form levelNew2024-03-04

Actions
Related to TYPO3 Core - Feature #103267: EXT:form Improvement: Field identifier should be editableNew2024-03-04

Actions
Actions
Copy link
 #1

Updated by Daniel Goerz 10 months ago

  • Related to Feature #102979: EXT:form Improvement: Make list of forms filterable added
Actions
Copy link
 #2

Updated by Daniel Goerz 10 months ago

  • Related to Feature #102865: Add PSR-14 Event to modify loaded form definition added
Actions
Copy link
 #3

Updated by Daniel Goerz 9 months ago

  • Related to Feature #103266: EXT:form Improvement: Introduce Possibility for Validators at form level added
Actions
Copy link
 #4

Updated by Daniel Goerz 9 months ago

  • Related to Feature #103267: EXT:form Improvement: Field identifier should be editable added
Actions
Copy link
 #5

Updated by Georg Ringer 6 months ago

how it looks now

Actions
Copy link
 #6

Updated by Gerrit Code Review 6 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84401

Actions
Copy link
 #7

Updated by Annett Jähnichen 6 months ago

Hi,

I'm not quite sure about the lock icon.
In most places in the backend (list module) we render an empty field or the button not at all instead of a disabled button.
Maybe that would be the better option here?

Actions
Copy link
 #8

Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84401

Actions
Copy link
 #9

Updated by Daniel Goerz about 1 month ago

Annett Jähnichen wrote in #note-7:

Hi,

I'm not quite sure about the lock icon.
In most places in the backend (list module) we render an empty field or the button not at all instead of a disabled button.
Maybe that would be the better option here?

I think "render an empty field or the button not at all" would also be a great improvement.

Actions
Copy link

Also available in: Atom PDF