Project

General

Profile

Actions

Task #103028

open

Refactoring DefaultTcaSchema to reduce redundant code

Added by Cyrill Gsell 5 months ago. Updated 12 days ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
Database API (Doctrine DBAL)
Target version:
Start date:
2024-02-03
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
13
PHP Version:
8.2
Tags:
Complexity:
easy
Sprint Focus:

Description

I would like to simplify the TYPO3\CMS\Core\Database\Schema\DefaultTcaSchema class by replacing all the "foreach ($tableDefinition['columns'] as $fieldName => $fieldConfig)" calls with one foreach. I would suggest a mapping class which returns the column type and its options depending on the given tca configuration.

Optional:
  • If wanted I could add an PSR-14 event allowing to override the column type and options with an event listener.

I already have a running prototype, if you think this would be useful I would finish it and update the tests if needed before I push it for a review.

P.S. I created this task to get startet in the TYPO3 contribution by getting to know the whole process.


Related issues 2 (1 open1 closed)

Related to TYPO3 Core - Feature #101553: Auto-create DB fields from TCA columnsIn Progress2023-10-13

Actions
Related to TYPO3 Core - Task #104110: Streamline DefaultTcaSchemaResolved2024-06-14

Actions
Actions #1

Updated by Benni Mack 5 months ago

  • Target version changed from 13.0 to 13.1
Actions #2

Updated by Sven Wappler 3 months ago

Perhaps this would be a good reason to wish for the possibility to manipulate the table generation via extension. The background is that I would like to make the tag field type available in TYPO3, similar to category. For this it would be very practical if I only need to add the field to the various tables via TCA override, the necessary sql field would be added automatically.

Actions #3

Updated by Benni Mack about 2 months ago

  • Target version changed from 13.1 to 13.2
Actions #4

Updated by Christian Kuhn 12 days ago

Actions #5

Updated by Christian Kuhn 12 days ago ยท Edited

events may be problematic in ext:install related code. the multiple foreach loops have been cleaned up with #104110.

Actions #6

Updated by Christian Kuhn 12 days ago

  • Related to Task #104110: Streamline DefaultTcaSchema added
Actions

Also available in: Atom PDF