Bug #103157: Image referenced by `EXT:` does not work in TYPO3 subfolder installation - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #103157

open

Image referenced by `EXT:` does not work in TYPO3 subfolder installation

Added by Ayke Halder 2 months ago. Updated about 2 months ago.

Status:

Under Review

Priority:

Should have

Assignee:

Category:

File Abstraction Layer (FAL)

Target version:

Candidate for patchlevel

Start date:

2024-02-20

Due date:

% Done:

Estimated time:

TYPO3 Version:

PHP Version:

8.2

Tags:

Complexity:

Is Regression:

Yes

Sprint Focus:

Description

In a composer-based TYPO3 subfolder installation ( e.g. BE https://example.org/subfolder/typo3 ) images refrenced by `EXT:` are not working.

<f:image src="EXT:example/Resources/Public/Images/test.svg" />

#1509741914 TYPO3Fluid\Fluid\Core\ViewHelper\Exception

Unable to render image tag in "pages:123": File /subfolder/_assets/abcdef0123456789abcdef0123456789/Images/test.svg does not exist.

Related issues 2 (1 open — 1 closed)

Actions

Copy link

Updated by Ayke Halder 2 months ago

Related to Bug #95543: Processed files of static images are stored outside document root added

Actions

Copy link

Updated by Gerrit Code Review 2 months ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83043

Actions

Copy link

Updated by Ayke Halder 2 months ago

Description updated (diff)

Actions

Copy link

Updated by Benjamin Franzke 2 months ago

Hm, the fix itself it fine, but I guess you'll run into alot of issues with that setup, since the subfolder you're referring to is probably a symlink to some/projectpath/public.

That means that `Environment::getPublicPath()` will be wrong (pointing to `some/projectpath/public`) and thus basically every place that uses `Environment::getPublicPath()` is broken for you.

Can you canfirm that you're using such a symlink to the public folder?
(Please share some more details, composer.json and directory structure)

Actions

Copy link

Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83043

Actions

Copy link

Updated by Ayke Halder 2 months ago · Edited

@Benjamin Franzke Thank you for looking into this!

I'm not really using symlinks, instead I use this special configuration in composer.json:

{
  "extra": {
    "typo3/cms": {
      "web-dir": "public/subfolder" 
    }
}

composer.json [click to open]composer.json [click to open]

{
  "config": {
    "vendor-dir": "vendor",
    "classmap-authoritative": false,
    "allow-plugins": {
      "typo3/class-alias-loader": true,
      "typo3/cms-composer-installers": true,
      "helhum/dotenv-connector": true,
      "helhum/typo3-console-plugin": true,
      "cweagans/composer-patches": true
    }
  },
  "repositories": [
    {
      "type": "path",
      "url": "../typo3-composer-dev/example-extension",
      "options": {
        "symlink": true
      }
    },
    {
      "type": "artifact",
      "url": "../typo3-composer-artifacts/" 
    },
    {
      "type": "composer",
      "url": "https://composer.typo3.org/" 
    }
  ],
  "name": "example-company/example-typo3-cms-distribution",
  "require": {
    "typo3/cms-adminpanel": "^12.4",
    "typo3/cms-backend": "^12.4",
    "typo3/cms-belog": "^12.4",
    "typo3/cms-beuser": "^12.4",
    "typo3/cms-core": "^12.4",
    "typo3/cms-extbase": "^12.4",
    "typo3/cms-extensionmanager": "^12.4",
    "typo3/cms-felogin": "^12.4",
    "typo3/cms-filelist": "^12.4",
    "typo3/cms-fluid": "^12.4",
    "typo3/cms-form": "^12.4",
    "typo3/cms-frontend": "^12.4",
    "typo3/cms-impexp": "^12.4",
    "typo3/cms-info": "^12.4",
    "typo3/cms-install": "^12.4",
    "typo3/cms-linkvalidator": "^12.4",
    "typo3/cms-lowlevel": "^12.4",
    "typo3/cms-opendocs": "^12.4",
    "typo3/cms-recordlist": "^12.4",
    "typo3/cms-recycler": "^12.4",
    "typo3/cms-redirects": "^12.4",
    "typo3/cms-reports": "^12.4",
    "typo3/cms-scheduler": "^12.4",
    "typo3/cms-seo": "^12.4",
    "typo3/cms-setup": "^12.4",
    "typo3/cms-sys-note": "^12.4",
    "typo3/cms-t3editor": "^12.4",
    "typo3/cms-tstemplate": "^12.4",
    "typo3/cms-viewpage": "^12.4",
    "typo3/minimal": "^12.4",
    "helhum/typo3-console": "^v8.1.1",
    "example-company/example-a": "*",
    "example-company/example-b": "*",
    "example-company/example-extension": "*",
    "cweagans/composer-patches": "^1.7" 
  },
  "require-dev": {
    "undkonsorten/typo3-auto-login": "~2.1.1" 
  },
  "scripts": {
    "folder-structure": [
      "@php vendor/bin/typo3 install:fixfolderstructure" 
    ],
    "ext-setup": [
      "@php vendor/bin/typo3 install:extensionsetupifpossible" 
    ],
    "language-update": [
      "@php vendor/bin/typo3 language:update" 
    ],
    "post-autoload-dump": [
      "@folder-structure",
      "@ext-setup",
      "@language-update" 
    ]
  },
  "extra": {
    "typo3/cms": {
      "cms-package-dir": "{$vendor-dir}/typo3/cms",
      "web-dir": "public/subfolder" 
    },
    "patches": {
      "typo3/cms-core": {
        "[BUGFIX] Make images referenced by EXT: work in subfolder installation": "https://github.com/rr-it/TYPO3.CMS/commit/cee8daaff8e41fd1b7a9857d1b1c286469b12c47.diff" 
      }
    }
  }
}

Directory structure [click to open]Directory structure [click to open]

/var/www/
├─ typo3-composer-artifacts/
│  ├─ example_a.zip
│  └─ example_b.zip
│
├─ typo3-composer-dev/
│  └─ example-extension/
│     ├─ Resources/
│     │  ├─ Private/
│     │  └─ Public/
│     │     └─ Images/
│     │        └─ test.svg
│     │
│     ├─ composer.json
│     └─ ext_emconf.php
│
└─ html/
   ├─ config/
   ├─ public/ <- https://example.org/
   │  └─ subfolder/ <- https://example.org/subfolder/
   │     ├─ _assets/
   │     │  ├─ 1ee1d3e909b58d32e30dcea666dd3224 -> ../../../vendor/typo3/cms-core/Resources/Public
   │     │  └─ abcdef0123456789abcdef0123456789 -> ../../../vendor/example-company/example-extension/Resources/Public
   │     │
   │     ├─ fileadmin/
   │     ├─ typo3/
   │     │  ├─ index.php
   │     │  └─ install.php
   │     │
   │     ├─ typo3temp/
   │     ├─ uploads/
   │     ├─ .htaccess
   │     └─ index.php
   │
   ├─ vendor/
   │  ├─ symfony/
   │  ├─ typo3/
   │  │  └─ cms-core/
   │  │     ├─ Resources/
   │  │     │  ├─ Private/
   │  │     │  └─ Public/
   │  │     │
   │  │     ├─ composer.json
   │  │     └─ ext_emconf.php
   │  │
   │  └─ example-company/
   │     └─ example-extension/ -> ../../../typo3-composer-dev/example-extension/ (symlink created by composer)
   │
   ├─ var/
   └─ composer.json

Actions

Copy link