Bug #104839
closedCKEditor YAML processing.HTMLparser_db.removeTags uses wrong syntax
100%
Description
File: EXT:rte-ckeditor/Configuration/RTE/Processing.yaml
Line removeTags: [center, font, link, meta, o:p, sdfield, strike, style, title, u]
This does not work at all. Parser does ignore this line and removes none of these tags. These configs are transported to TSconfig as-is. TSconfig expects a CSV (and no array) there!
Correct is: removeTags: center, font, link, meta, o:p, sdfield, strike, style, title, u
- then the parser removes the tags.
Discovered in v12, but I assume this never worked since the introduction of CKEditor.
I discovered this because CKEditor 5 does not allow getting rid of p-tags in RTE anymore (contrary to CKEditor 4, which had enterMode
and autoParagraph
settings). So at least the core persisting to DB should get rid of the p-tag once I add "p" to removeTags
. It did not work and it did also not work for any other tag. So I switched from Array to CSV, and it instantly worked.
I did not test other config options, but I can imagine that other configs are also using arrays where TSconfig expects CSV.
Be careful: If you fix this then ALL setups using the shipped default RTE Presets after the update will then suddenly respect this setting and remove tags upon saving. Maybe there are people that just use the default config but still want to keep tags and are just not aware that some tags actually are forbidden by default.
Updated by Garvin Hicking 2 months ago
- Status changed from New to In Progress
- Priority changed from Should have to Must have
Thanks, I sadly had not yet the opportunity to respond to this and investigate.
I can confirm your research, and this is a "bad one". The breaking change implications are not easy to weigh in. We're discussing now how to proceed with.
Updated by Gerrit Code Review 2 months ago
- Status changed from In Progress to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86047
Updated by Gerrit Code Review 2 months ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86047
Updated by Gerrit Code Review 2 months ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86047
Updated by Gerrit Code Review 2 months ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86047
Updated by Gerrit Code Review 2 months ago
Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86047
Updated by Gerrit Code Review 2 months ago
Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86047
Updated by Gerrit Code Review 2 months ago
Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86215
Updated by Garvin Hicking about 2 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 6edf734060d4329c7eb6f5c5a50cfe9d41cb2d34.
Updated by Georg Tiefenbrunn about 2 months ago
- Related to Bug #105254: PHP Warning: Undefined array key "removeTags." in typo3/cms-core/Classes/Html/HtmlParser.php added