TYPO3 Core

As mentioned by Olly, this bug is actually related to the TYPO3 Core, but I still wanted to submit it here first to discuss the solution with more workspace-savvy people.

A quick way to reproduce the problem:

1. place yourself in some workspace other than LIVE
2. make sure that the split-screen preview is enabled
3. create a new page and save it a first time
4. now that the page is saved, the "Save and view" icon becomes available: click on it

You should see the following result:

1. in the LIVE frame, there should be a broken rootline error
2. in the workspace preview frame, the new page can be previewed normally

Now move to Web > List module and click on the "View" icon. The result is not the same. The LIVE frame displays a nice error message saying: "New page! The previewed page is created in the workspace and has no counterpart in the live workspace.".

The error on "Save and view" happens because this command calls the version overlay of the page rather than the original page itself. The proper behavior is to call the page with its original uid and let TYPO3 do all the overlay stuff.

The attached patch fixes this behavior, by changing the popViewId parameter that's used during the "Save and view" process. The patch was made for TYPO3 4.4. I would like to discuss how best to make a TYPO3 4.5 version, given the cleaner splitting of version-related code that we have now.

Thanks in advance for your feedback. I hope the bug description is clear enough.

I haven't checked yet but I guess to trigger the preview everything is passed through - t3lib_beFunc::viewOnClick right? If so - I'd say it would be better to solve this issue there - this would imho be much more robust...

You are right. Actually this was my original approach, but at the time I had not identified the problem correctly. By the time I had found the right cause, I had switched solution ;-) But patching t3lib_beFunc::viewOnClick() also works. Done in attached v2 of the patch.

I guess the solution for 4.5 would imply to introduce a hook to manipulate the id in t3lib_beFunc::viewOnClick().

Hi,

just reviewed the affected functions (t3lib_pageSelect::getMountpointInfo(), t3lib_beFunc::getViewDomain()) and it seems that both more or less rely on live-pids too (both make the workspace-overlays internally on their own). So I assume that the patch we discussed earlier fully fits our needs.

The attached patch has been set as RFC patch to the typo3.teams.workspace newsgroup.

Cheers, Tolleiv

Committed to trunk (rev. 3490).