Project

General

Profile

Actions

Feature #11029

closed

Workspaces module: Row detail view

Added by Steffen Gebert almost 14 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2010-11-23
Due date:
2010-11-30
% Done:

70%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The workspaces module needs styling for the ExtJS grid's detail view (when you expand an entry).

The PNG file gives you some hints and lists the mistakes in the PSD (the live version has no comments and comments have no title).

Shared installation #1 is reserved for you.

Please make your changes in typo3/sysext/workspaces/Resources/Public/StyleSheet/module.css

You get this view by opening the "Workspaces" module.


Files

entwurf_4.5-workspaces_03-detail.psd (5.8 MB) entwurf_4.5-workspaces_03-detail.psd Photoshop file Steffen Gebert, 2010-11-23 20:42
workspaces-detail.png (323 KB) workspaces-detail.png PNG with some hints Steffen Gebert, 2010-11-23 20:42
f11029.diff (6.51 KB) f11029.diff Patch Steffen Gebert, 2010-12-01 01:14
workspaces-comments-arrow.gif (1.15 KB) workspaces-comments-arrow.gif Image Steffen Gebert, 2010-12-01 01:14
comment.PNG (2.75 KB) comment.PNG Tolleiv Nietsch, 2010-12-20 21:23
Actions #1

Updated by Steffen Gebert almost 14 years ago

  • Subject changed from Workspace module: Row detail view to Workspaces module: Row detail view
Actions #2

Updated by Berit Hlubek almost 14 years ago

  • Assignee set to Berit Hlubek
Actions #3

Updated by Berit Hlubek almost 14 years ago

  • Status changed from New to Accepted
Actions #4

Updated by Berit Hlubek almost 14 years ago

  • Status changed from Accepted to Needs Feedback
  • % Done changed from 0 to 70

Kind of ready in Firefox and Safari.
Was not able to test it in IEx due to javascript errors with mordernizr looked as if no workspaces-css-files are loaded at all.
Regarding the change comments the last comment has no margin via the pseudo-class last-child would be good to add some javascript functionality for the browsers which don't support pseudoclasses.

Updated by Steffen Gebert almost 14 years ago

Attached patch is the result of Berit's work.

Please test together with the pending Core RFC #16626

Place the image in Resources/Public/Images/

Actions #6

Updated by Steffen Gebert almost 14 years ago

  • Tracker changed from Task to Feature
  • Project changed from 1522 to 624
  • Category deleted (879)
Actions #7

Updated by Steffen Gebert almost 14 years ago

  • Assignee deleted (Berit Hlubek)

Could you please review and commit this ASAP? We'd like to make the last adjustments within the next days.

Thanks
Steffen

Actions #8

Updated by Sonja Schubert almost 14 years ago

  • Status changed from Needs Feedback to Under Review
  • Target version set to 4.5 Beta 3
Actions #9

Updated by Tolleiv Nietsch almost 14 years ago

looks good for me - I would definitely use this for beta3. Smaller improvements can follow later.

One thing I found: if the username is too long it's hidden behind the balloon (see screen)

Actions #10

Updated by Steffen Gebert almost 14 years ago

Would be nice, if you could commit this (Credits to Lars Zimmermann and Berit Jensen).

Thanks!

Actions #11

Updated by Tolleiv Nietsch almost 14 years ago

  • Status changed from Under Review to Resolved

Committed to trunk r3664 - Thanks to the entire Skin team :)

Actions #12

Updated by Michael Stucki almost 11 years ago

  • Category set to Workspaces
Actions #13

Updated by Michael Stucki almost 11 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
  • Target version deleted (4.5 Beta 3)
Actions #14

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF