Bug #11574: Workspaces grid: stages should "sit" on one line - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #11574

closed

Workspaces grid: stages should "sit" on one line

Added by Tolleiv Nietsch over 13 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Susanne Moog

Category:

Workspaces

Target version:

Start date:

2010-12-19

Due date:

% Done:

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Select a workspace and make changes to some pages.
Go to the workspaces module and see send some of the changes to different stages:

Within the grid all stage-labels should "sit" on one line no matter if hovered or not

Files

Download all files

stages.PNG (3.61 KB) stages.PNG		Tolleiv Nietsch, 2010-12-19 09:29
11574.patch (1.06 KB) 11574.patch		Sonja Schubert, 2011-01-08 17:04
11574_v2.diff (748 Bytes) 11574_v2.diff		Susanne Moog, 2011-01-20 20:03
11574_v3.diff (754 Bytes) 11574_v3.diff		Susanne Moog, 2011-01-21 14:39

Actions

Copy link

Updated by Steffen Gebert over 13 years ago

Tracker changed from Bug to Task
Project changed from 624 to 1522

Actions

Copy link

Updated by Steffen Gebert over 13 years ago

Subject changed from Styling - stages should "sit" on one line to Workspaces grid: stages should "sit" on one line

Actions

Copy link

Updated by Raphael Weber over 13 years ago

Status changed from Accepted to Needs Feedback

This is no issue of the styling, i think. If the staus is changed (e.g. from "Editing" to "Stage 1") there´s the following HTML-Element missing:

<span class="t3-icon t3-icon-empty t3-icon-empty-empty" id="ext-gen128">&nbsp;</span>

Actions

Copy link

Updated by Steffen Gebert over 13 years ago

Thanks Raphael,

do I understand correctly that e.g. Editing has a different markup than Review and thus only the mentioned <span> should be outputted?

Steffen

Actions

Copy link

Updated by Raphael Weber over 13 years ago

Yes, the first child of the div.x-grid3-cell-inner containing the text "Editing" is the span.t3-icon-empty. This element is missing, when the cell contains the text "Stage 1".

Here´s the complete Output taken from Firebug:

"Editing"¶

<div unselectable="on" class="x-grid3-cell-inner x-grid3-col-label_Stage" id="ext-gen118"><span class="t3-icon t3-icon-empty t3-icon-empty-empty">&nbsp;</span>Editing<img class="x-action-col-icon x-action-col-0  " src="http://web3.playground.typo3-anbieter.de/typo3/gfx/clear.gif" alt=""><img ext:qtip="Send record to next Stage" class="x-action-col-icon x-action-col-1 t3-icon t3-icon-extensions t3-icon-extensions-workspaces t3-icon-workspaces-sendtonextstage " src="http://web3.playground.typo3-anbieter.de/typo3/gfx/clear.gif" alt=""></div>

"Stage 1"¶

<div unselectable="on" class="x-grid3-cell-inner x-grid3-col-label_Stage"><img ext:qtip="Send record to previous Stage" class="x-action-col-icon x-action-col-0 t3-icon t3-icon-extensions t3-icon-extensions-workspaces t3-icon-workspaces-sendtoprevstage " src="http://web3.playground.typo3-anbieter.de/typo3/gfx/clear.gif" alt="">Stage 1<img class="x-action-col-icon x-action-col-0  " src="http://web3.playground.typo3-anbieter.de/typo3/gfx/clear.gif" alt=""><img ext:qtip="Send record to next Stage" class="x-action-col-icon x-action-col-1 t3-icon t3-icon-extensions t3-icon-extensions-workspaces t3-icon-workspaces-sendtonextstage " src="http://web3.playground.typo3-anbieter.de/typo3/gfx/clear.gif" alt=""></div>

[web3.playground.typo3-anbieter.de -> Module: Workspace, Demo-Workspace -> Page: /Home/Customizing TYPO3/]

Actions

Copy link

Updated by Steffen Gebert over 13 years ago

Thanks, Raphael!

I will hand it back to the Workspaces Team to add the needed markup.

Actions

Copy link

Updated by Steffen Gebert over 13 years ago

Tracker changed from Task to Bug
Project changed from 1522 to 624

Actions

Copy link

Updated by Tolleiv Nietsch over 13 years ago

Category set to Bugs
Status changed from Needs Feedback to Accepted
Target version set to 4.5 RC1

Actions

Copy link

Updated by Sonja Schubert over 13 years ago

File 11574.patch 11574.patch added
Status changed from Accepted to Needs Feedback

I attached a patch which adds the <span> empty-icon tag always as you requested.

But it's not solved, yet. In "non-hover" status the stages are on one line now, but in "hover" the stages "Stage 1" and so on are moving to the right to show the sendToPrev Button. Do you solve this via CSS now or did I get something wrong and we need something else in HTML markup?

Actions

Copy link

#10