TYPO3 Core

And here's some code from my locally modified version of "tagpack" to show how the proposed hook is used:

/**
 * This method responds to a hook in the workspaces module
 * It gets the tags for both the live and workspace version of the given record
 * and returns information about said tags
 *
 * @param object $parameter: container for information about the record being handled
 * @param array $diffReturnArray: list of differences per field
 * @param array $liveReturnArray: list of all fields from the live record
 * @param t3lib_diff $t3lib_diff: instance of the t3lib_diff class
 * @return void
 */
public function modifyDifferenceArray($parameter, &$diffReturnArray, &$liveReturnArray, $t3lib_diff) {
    $workspaceTags = $this->getTagsAsString($parameter->table, $parameter->uid);
    $liveTags = $this->getTagsAsString($parameter->table, $parameter->t3ver_oid);
    $liveReturnArray[] = array(
        'label' => 'Tags',
        'content' => $liveTags
    );
    $diffReturnArray[] = array(
        'label' => 'Tags',
        'content' => $t3lib_diff->makeDiffDisplay($liveTags, $workspaceTags)
    );
}

/**
 * Get the tags for a given record and concatenates their names
 *
 * @param string $table: name of the table to look up relations for
 * @param integer $id: primary of the record to look up relations for
 * @return string All tags attached to the record, comma-separated
 */
protected function getTagsAsString($table, $id) {
    $tagsString = '';
    $tags = tx_tagpack_api::getAttachedTagsForElement($id, $table, FALSE, TRUE, TRUE);
    foreach($tags as $tagInformation) {
        if (!empty($tagsString)) {
            $tagsString .= ', ';
        }
        $tagsString .= $tagInformation['name'];
    }
    return $tagsString;
}

Tolleiv Nietsch wrote:

Sounds good - I'd prefer to check if this patch could also work with TemplaVoila and with Languagevisibility before we commit it.

OK. I don't know about Languagevisibility, but I guess it should be ok with TemplaVoila, because the patch simply makes it possible to manipulate the diff and live arrays.

The issue I can see is that those 2 arrays are simple indexed array, so it's not easy to find a given entry (in my case I was adding one, so I didn't feel the need). So maybe the workspaces code can be modified a bit further to use the field names as keys for the array and make it associative. I don't think it will have an impact on the display and it would make it easy then to find a particular entry and modify it.

Looking again at this issue, I see that the target version has been set to 4.6. I don't think it's a good idea. I know that we have a policy of not introducing hooks in minor version updates, but there are special cases. If - as we wish it to be - my proposed hook can also be used for TemplaVoila - can you really imagine that it will take an upgrade to 4.6 to display TV differences, while 4.5 is expected to be supported for 3 years?

I will raise this matter in the v4 list (about the general policy of adding hooks in stable branches). As I already said, I can hardly imagine that this does not get solved in 4.5 over the whole course of LTS.

The principle of introducing new hooks in TYPO3 4.5 has been accepted, when these hooks are used by system extensions. So I'll go ahead and submit this officially. That goes through Gerrit too now, right?

Patch set 1 of change Ibe15ae0f5a57ecd3988e62b10b58a30976ea3f18 has been pushed to the review server.
It is available at http://review.typo3.org/2955

Patch set 1 of change Ibe15ae0f5a57ecd3988e62b10b58a30976ea3f18 has been pushed to the review server.
It is available at http://review.typo3.org/2957