Feature #14463
closedMenu doesn't expand if ".special" is set
0%
Description
In the source of class.tslib_menu.php in line 267 is noted that the expanding of menus doesn't work when the "special" feature is used.
I created a patch so it is possible to expand menus when "special=directory" is set.
I don't know if it is wanted to add such a feature to the core.
You can get the patch at:
http://www.libelle.at/kraftb/sp_dir_expand.patch
or use the uploaded file
(issue imported from #M633)
Files
Updated by Wolfgang Klinger almost 20 years ago
If you provide a diff, please use the unified style (as already mentioned on bugs.typo3.org) (diff -u)
Thanks!
Updated by Bernhard Kraft almost 20 years ago
The online version of the diff
http://www.libelle.at/kraftb/sp_dir_expand.patch
is already in the unified style. I upload the patch again now in a unified form
Updated by Michael Stucki almost 20 years ago
I did remove the old patch. Thanks, Bernhard.
Updated by Bernhard Kraft almost 20 years ago
here's how to apply the patch:
change dir to TYPO3ROOT/tslib/
then type:
patch -p 0 ./class.tslib_menu.php < /DIRTOPATCH/sp_dir_expand.patch
Updated by Wolfgang Klinger over 19 years ago
Why is this not included in TYPO3 3.8?? You have a problem description and a patch -- all you need... hmmm
Updated by Bernhard Kraft over 19 years ago
Because I hadn't had any feedback here or via mail if it works as expected and no problems occur.
Did you test it ? Does it work as it should ?
Updated by Wolfgang Klinger over 19 years ago
Sure, made an extension for 3.8 out of it (XCLASS) and it works as expected... you should have asked beforehand ;-)
Updated by Bernhard Kraft over 19 years ago
That's very good. I just assigned the bug to myself. Will include the patch-request in my next mail to Kasper.
Updated by Bernhard Kraft almost 19 years ago
The file
"bug_633_2006-01-06.diff"
attached to this bug fixes the issue and was sent to the core-list as CVS patch request:
http://lists.netfielders.de/pipermail/typo3-team-core/2006-January/001138.html
please report problems
greets,
Bernhard
Updated by Andreas Wolf about 18 years ago
I tested the patch and it works, but only if special.value does not point to a mount-point. That's the setup I have here and so the patch is useless for me... :(
Edit: It works for non-mountpointed special.values even without the patch in T3 4.0.1.
Updated by Dylgerov over 17 years ago
The patch works. Please use it in future versions.
My site uses such setup and not works on Typo3 4.1.1 without this very usefull patch:
temp.left_menu.20 = HMENU
temp.left_menu.20.special = directory
temp.left_menu.20.special.value = {$localuid}
temp.left_menu.20.1 = TMENU
temp.left_menu.20.1 {
NO = 1
NO.allWrap = <div class="menu1-level1-no"> | </div>
ACT = 1
ACT.allWrap = <div class="menu1-level1-act"> | </div>
}
temp.left_menu.20.2 = TMENU
temp.left_menu.20.2 {
NO.allWrap = <div class="menu1-level2-no"> | </div>
ACT = 1
ACT.allWrap = <div class="menu1-level2-act"> | </div>
}
Updated by Krisztian Pal about 17 years ago
I downloaded the patch, but cannot manage to apply it on a windows server. There is no directory tslib in typo3 4.1.1 anyway.
Would you mind please to publish the source code or at least the files which I can copy in the appropriate folders manually?
Thanks a lot in advance!
Updated by Francois Suter about 17 years ago
I sent a mail to the bugs list on Wednesday in the hope that it would make things move again for this bug...
Updated by Michael Stucki about 17 years ago
Hi Francois,
you can create your own RFC on the core list now! See http://news.typo3.org/news/article/core-development-mailinglist-now-open-for-community-involvement/
- michael
Updated by Alex Widschwendter about 17 years ago
hi all,
i can confirm the working patch for T3 version 4.1.2
please add this patch to the next release.
tia alex
Updated by Bernhard Kraft about 17 years ago
Hi !
I submitted the patch to SVN right now. So this patch will be in the new version 4.1.2
One thing to notice: Until now it even worked without a problem when you had special.value set to the uid of a page which had the rootlevel-flag set.
So you could just notice this bug when you created a "special = directory" menu where the page from which a menu was created didn't have the rootline-flag set (which is the case most of the time if u use the "sitemap" content element for example - which creates its output using a TMENU) ...
greets,
Bernhard