Project

General

Profile

Actions

Feature #14463

closed

Menu doesn't expand if ".special" is set

Added by Bernhard Kraft almost 20 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Should have
Category:
Backend API
Target version:
-
Start date:
2004-12-21
Due date:
% Done:

0%

Estimated time:
PHP Version:
4.3
Tags:
Complexity:
Sprint Focus:

Description

In the source of class.tslib_menu.php in line 267 is noted that the expanding of menus doesn't work when the "special" feature is used.
I created a patch so it is possible to expand menus when "special=directory" is set.

I don't know if it is wanted to add such a feature to the core.

You can get the patch at:
http://www.libelle.at/kraftb/sp_dir_expand.patch
or use the uploaded file
(issue imported from #M633)


Files

0000633-sp_dir_expand.patch (2.08 KB) 0000633-sp_dir_expand.patch Administrator Admin, 2004-12-22 15:26
bug_633_2006-01-06.diff (3.6 KB) bug_633_2006-01-06.diff Administrator Admin, 2006-01-18 19:53

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #20208: 00633 not fixed in latest versions of Typo3ClosedChristian Kuhn2009-03-19

Actions
Is duplicate of TYPO3 Core - Bug #16026: special=directory does not include submenu entriesClosed2006-04-10

Actions
Actions #1

Updated by Wolfgang Klinger almost 20 years ago

If you provide a diff, please use the unified style (as already mentioned on bugs.typo3.org) (diff -u)

Thanks!

Actions #2

Updated by Bernhard Kraft almost 20 years ago

The online version of the diff
http://www.libelle.at/kraftb/sp_dir_expand.patch
is already in the unified style. I upload the patch again now in a unified form

Actions #3

Updated by Michael Stucki almost 20 years ago

I did remove the old patch. Thanks, Bernhard.

Actions #4

Updated by Bernhard Kraft almost 20 years ago

here's how to apply the patch:
change dir to TYPO3ROOT/tslib/
then type:
patch -p 0 ./class.tslib_menu.php < /DIRTOPATCH/sp_dir_expand.patch

Actions #5

Updated by Wolfgang Klinger over 19 years ago

Why is this not included in TYPO3 3.8?? You have a problem description and a patch -- all you need... hmmm

Actions #6

Updated by Bernhard Kraft over 19 years ago

Because I hadn't had any feedback here or via mail if it works as expected and no problems occur.

Did you test it ? Does it work as it should ?

Actions #7

Updated by Wolfgang Klinger over 19 years ago

Sure, made an extension for 3.8 out of it (XCLASS) and it works as expected... you should have asked beforehand ;-)

Actions #8

Updated by Bernhard Kraft over 19 years ago

That's very good. I just assigned the bug to myself. Will include the patch-request in my next mail to Kasper.

Actions #9

Updated by Bernhard Kraft almost 19 years ago

The file
"bug_633_2006-01-06.diff"
attached to this bug fixes the issue and was sent to the core-list as CVS patch request:
http://lists.netfielders.de/pipermail/typo3-team-core/2006-January/001138.html

please report problems

greets,
Bernhard

Actions #10

Updated by Wolfgang Klinger over 18 years ago

What's the current status here?

Actions #11

Updated by Andreas Wolf about 18 years ago

I tested the patch and it works, but only if special.value does not point to a mount-point. That's the setup I have here and so the patch is useless for me... :(

Edit: It works for non-mountpointed special.values even without the patch in T3 4.0.1.

Actions #12

Updated by Dylgerov over 17 years ago

The patch works. Please use it in future versions.

My site uses such setup and not works on Typo3 4.1.1 without this very usefull patch:

temp.left_menu.20 = HMENU
temp.left_menu.20.special = directory
temp.left_menu.20.special.value = {$localuid}
temp.left_menu.20.1 = TMENU
temp.left_menu.20.1 {
NO = 1
NO.allWrap = <div class="menu1-level1-no"> | </div>
ACT = 1
ACT.allWrap = <div class="menu1-level1-act"> | </div>
}
temp.left_menu.20.2 = TMENU
temp.left_menu.20.2 {
NO.allWrap = <div class="menu1-level2-no"> | </div>
ACT = 1
ACT.allWrap = <div class="menu1-level2-act"> | </div>
}

Actions #13

Updated by Krisztian Pal about 17 years ago

I downloaded the patch, but cannot manage to apply it on a windows server. There is no directory tslib in typo3 4.1.1 anyway.

Would you mind please to publish the source code or at least the files which I can copy in the appropriate folders manually?

Thanks a lot in advance!

Actions #14

Updated by Francois Suter about 17 years ago

I sent a mail to the bugs list on Wednesday in the hope that it would make things move again for this bug...

Actions #15

Updated by Michael Stucki about 17 years ago

Hi Francois,

you can create your own RFC on the core list now! See http://news.typo3.org/news/article/core-development-mailinglist-now-open-for-community-involvement/

- michael

Actions #16

Updated by Alex Widschwendter about 17 years ago

hi all,

i can confirm the working patch for T3 version 4.1.2

please add this patch to the next release.

tia alex

Actions #17

Updated by Bernhard Kraft about 17 years ago

Hi !

I submitted the patch to SVN right now. So this patch will be in the new version 4.1.2

One thing to notice: Until now it even worked without a problem when you had special.value set to the uid of a page which had the rootlevel-flag set.

So you could just notice this bug when you created a "special = directory" menu where the page from which a menu was created didn't have the rootline-flag set (which is the case most of the time if u use the "sitemap" content element for example - which creates its output using a TMENU) ...

greets,
Bernhard

Actions #18

Updated by Ingo Renner almost 17 years ago

comitted to trunk

Actions

Also available in: Atom PDF