Project

General

Profile

Actions

Bug #15224

closed

NOTE to 1518: Option .showHiddenPages for "module.preview" obsolete?

Added by Christian Trabold over 18 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2005-11-20
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.0
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Hello Sebastian,

the following TSconfig settings

admPanel {
enable.preview = 1
module.preview.showHiddenPages = 1
module.preview.showHiddenRecords = 0
}

or

admPanel {
enable.preview = 1
module.preview.showHiddenPages = 0
module.preview.showHiddenRecords = 1
}

result in the same: Hidden pages AND content elements are visible via preview.

Is that the desired functionality?

As I understand these options:

"module.preview.showHiddenPages = 1" shows hidden pages only.

"module.preview.showHiddenRecords = 1" shows hidden records on pages / content elements - but no hidden pages itself.

OR

"module.preview.showHiddenPages = 1" shows hidden pages only.

"module.preview.showHiddenRecords = 1" overrides "showHiddenPages" and shows ALL records.

What do you think about this?

Wanted to add a note on #14999, but that was not possible. :(
(issue imported from #M1906)


Files

bug_1906_part1.patch (1.28 KB) bug_1906_part1.patch Administrator Admin, 2005-12-19 20:19

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Feature #14999: override admin panel values from TSConfigClosedSebastian Kurfuerst2005-10-02

Actions
Related to TYPO3 Core - Bug #16551: Cannot reset settings via admPanel.overrideClosed2006-09-11

Actions
Actions #1

Updated by Sebastian Kurfuerst over 18 years ago

i'll check this.
Greets, Sebastian

Actions #2

Updated by Sebastian Kurfuerst over 18 years ago

I just checked the problem, and it somehow relates to workspaces.
I'll contact Kasper about it.
Greets, Sebastian

Actions #3

Updated by Sebastian Kurfuerst over 18 years ago

Ho.
I contacted Kasper a while ago about this problem and he wanted to check it.
Greets, Sebastian

Actions #4

Updated by Christian Trabold over 18 years ago

Thanks Sebastian for your efforts!

Actions #5

Updated by Christian Trabold over 18 years ago

Hello Sebastian, some more notes on the admin panel. Tomorrow is advent 3rd ;)

Currently the settings for the Admin-Panel are only affecting the proccessing of the values - not the display of the panel itself. Most important, the default settings are not visible for the user and IMHO "useless" fields are shown. Question is: Why should I see a field which I can not change nor see the value... (More dramatic: what the hack happens with my options I set?)

What do you think about this:

All fields are shown and empty per default, if the section is enabled.

Now, setting default values could work likes this:

admPanel {
enable.cache = 1
module.cache.default.noCache = 1
}

This enables the checkbox as default but allows users to change the field.

To force a value type this:

admPanel {
enable.cache = 1
module.cache.override.noCache = 1
}

That forces the no cache option to be set - user changes are ignored.

Hiding the checkbox could be done like this:

admPanel {
enable.cache = 1
module.cache.noCache = 0
}

To hide the complete field but force the no cache option per default write this:

admPanel {
enable.cache = 1
module.cache.noCache = 0
module.cache.override.noCache = 1
}

So the TSconfig works like "setup.override". A concept that admins already know from the setup-config. Sorry, but currently I see a broken concept here.

And I know that the sourcecode would become a bit more complex. But on the other hand this could make the admin panel more usable, powerfull, intuitive and more "economic".

I would love to hear your opinion about it. Thanks!

Christian

PS:

A possible feature for Admin-Panel?

- The Checkbox for the field "simulateDate" could assign the current date (like normal BE-Forms do)

Actions #6

Updated by Sebastian Kurfuerst over 18 years ago

Hi Christian,

I see your point and I think it makes sense so far.I am not sure if the override, default and "display" should be the first key index, like:

override.module.cache.noCache=1
default.module.cache.noCache=1
display.module.cache.noCache=1

for me, this is nicer as this is IMO the way it is done in TSconfig.
What do you think?
Greets, Sebastian

Actions #7

Updated by Christian Trabold over 18 years ago

Hello Sebastian,

1) The Naming: What do you think of "enable" or "hide" instead of "display"? If you use "display" you'll have three possibiblities to hide/deactivate something "hide", "enable" and "display", which is IMHO too much wording for the same function.

2) The Syntax: I really don't know what's nicer at the moment so I just post some examples - further comments will follow:

(2.1)
admPanel {
hide = 0

enable.all = 0
enable.preview = 1
module.hide {
preview.showHiddenRecords = 1
preview.simulateDate = 1
}
module.default {
preview.showHiddenPages = 0
preview.simulateDate = 0160542800
}
module.override {
preview.simulateUserGroup = 0
}
}

compared to (2.2)

admPanel {
hide = 0

enable.all = 0
enable.preview = 1
hide.module {
preview.showHiddenRecords = 1
}
default.module {
preview.showHiddenPages = 0
preview.simulateDate = 0160542800
}
hide.module {
preview.simulateDate = 1
preview.simulateUserGroup = 0
}
}

2.2 is more the old "enable.X" slang and so more uniform to the present syntax what could it make more intuitive for users.

While writing I get the feeling, that 2.2-Syntax would be smarter and more speakable. So you got my point ;)

3) The simplicity: What about erasing the "module"-Part? I know, that's simply not possible because of holy backwards-compatibility, but how would that be? SCNR

Actions #8

Updated by Sebastian Kurfuerst over 18 years ago

(3) makes sense IMO. There is no backwards compatibility to care about here as the notation changed anyways. Old settings will still work.
Greets, Sebastian

Actions #9

Updated by Christian Trabold over 18 years ago

FYI regarding the field "Simulate usergroup":

The user can choose FE-Groups which are in recyclers and / or are hidden.

(should this go into another issue?)

Actions #10

Updated by Sebastian Kurfuerst over 18 years ago

"The user can choose FE-Groups which are in recyclers and / or are hidden."
Hi, is this already present in 3.8.0? If yes, please open another issue.
Greets, Sebastian

Actions #11

Updated by Sebastian Kurfuerst over 18 years ago

Hi,
is somebody able to work on this on a short-term basis so the new notation could get into TYPO3 4.0? I maybe won't have time for this.

Greets, Sebastian

Actions #12

Updated by Sebastian Kurfuerst over 18 years ago

the current patch only implements the "override" possibility and changes the syntax from module.... to override....
This is no problem as the last patch 1518 is in no TYPO3 version except CVS yet and we don't have backwards compliancy to care about.
Greets, Sebastian

Actions #13

Updated by Christian Trabold over 18 years ago

Hi Sebastian,

I will investigate your patch, test and probably expand the options.

But I'm really busy right now - maybe I get my "72 hour-day" pre-x-mas. ;)

I'll keep you informed.

Actions #14

Updated by Sebastian Kurfuerst over 18 years ago

Hi,
the "override" stuff is in CVS!
Greets, Sebastian

Actions #15

Updated by Christian Trabold over 18 years ago

FYI: I'm working on that during the bugparty.

Actions #16

Updated by Christian Trabold over 18 years ago

sorry, but I don't find the time to work on this :(

I made some basic conceptional brainwork / investigated the code on the bugparty but nothing special.

I'm verry sorry.

Actions #17

Updated by Christian Trabold over 18 years ago

Hi!

I just checked out the override-feature with

admPanel {
hide = 0

enable.all = 0
enable.edit = 1
override.edit.displayFieldIcons = 0
override.edit.displayIcons = 0
}

and reconized, that the user can enable eg. the icons for frondend-editing by just clicking "Display Edit Icons" (and "Update" of course).

So the "override" looks more like a "default" because the user input is not overriden in any way.

That's what I expected:

The checkbox "Display Edit Icons" is not checked by default. If the user checks it, it will always toggle back after "Update", because the value from TSconfig overrides says so.

a) Bug or feature? Or a false expectation? ;)

b) You mentioned (@skype), that it would be very comlex the add the concept we "talked" about in notes #4477, #4481, #4508 and #4510 in this issue.

Could you provide some more background information on this? Maybe we could share some ideas to get this done?

Greetings,

Christian

Actions #18

Updated by Kasper Skårhøj over 18 years ago

Since this is about display, configuration of the Admin panel I will allow you to figure out how it works best. It is not a critical core feature for me to look at, sorry.

Sebastian; How did you see it affect workspaces? Was that a bug?

Actions #19

Updated by Michael Stucki almost 18 years ago

Could this be related with issue #16551? Apparently setting a property to "0" is not recognized and thus the override will fail.

Actions #20

Updated by Peter Niederlag over 17 years ago

admPanel.hide=1
admPanel.enable.preview = 1
admPanel.override.preview.showHiddenPages = 1
admPanel.override.preview.showHiddenRecords = 1

was reported to me by a user to not show hidden records as of TYPO3 4.0.2

Actions #21

Updated by Peter Niederlag over 17 years ago

As I have noticed today the whole preview thingy from adminPanel/TSconfig.override does not work correctly. :-<

enabling any kind of preview in the admPanel will always show all hidden CE's

Actions #22

Updated by Susanne Moog almost 13 years ago

  • Target version deleted (0)
  • PHP Version deleted (4)

Is this still an issue?

Actions #23

Updated by Alexander Opitz over 11 years ago

  • Status changed from Needs Feedback to Closed

No response in over 1 year => closed.

Actions

Also available in: Atom PDF