Feature #16864
closed
Function pi_wrapInBaseClass in tslib/class.tslib_pibase.php
Added by Thomas Janke almost 18 years ago.
Updated about 6 years ago.
Description
This function produces div-tags around html-output of certain extensions (newloginbox).
Generated comments can be disabled via TS config.disablePrefixComment = 1 but the div-tags will allway produced.
It would be nice if this feature (div-tag-generation around plugin-code) could be disabled vi TS. So that we have more control over the generated html and more flexibility.
The problem was already discussed at typo3-german@lists.typo3.org (17.01. / 11:04 Code-Ă„nderungen im CORE...)
Greeting und thank a lot Thomas
(issue imported from #M4801)
Files
I agree to the statement, that such wraps should be set in typoscript and there should be default setting for it. The wrap you mentioned is mostly used for CSS reasons, to give it a CSS-namespace.
But, there could be an extension-dependent configuration like this one:
plugin.tx_myext_pi1 {
disableWrapInBaseClass = 1
}
If the php extension file itself (e.g. pi1/class.tx_myext_pi1.php) puts the $conf to $this->conf in the main-function, pi_wrapInBaseClass could get knowledge of this configuration.
+1
A developer needs to have control over every piece of HTML code outputed. No matter how "harmless" a div tag looks, there are situations when an extra div is a pain in the...
Since we cannot do this per-extension, I uploaded a patch to disable this globally. Use config.disableBaseClassWrap = 1 in your TS setup
Thank you! Finally some control back ;)
I think it should be possible to do it for extension. The code in pi_wrapInBaseClass should check for the TSConfig options that is constructed like:
$TSConfigKey = 'plugin.' . $this->prefixId . 'disableWrapInBaseClass';
yes, i think too, because some extensions come with default css defined with the wrapclass, otherwise this css will not work any longer.
So the easies way would be a setting for extension, that prevent the wrapping like
plugin.tx_ext_pi1.disableWrapInBaseClass = 1
and in pi_wrapInBaseClass
$content = $this->conf['disableWrapInBaseClass '] ? $str : '<div class....
Resolved as duplicate of #19809
- Assignee deleted (
Michael Scharkow)
- Target version deleted (
0)
- PHP Version deleted (
4)
- Status changed from Resolved to Closed
Also available in: Atom
PDF