TYPO3 Core

Added new patch with cleaned up code and some changes requested by Dimitri.

Hi Christian,

there is a big misunderstanding which has been in this extension for quite some time now: A x.y.2 version is not a development version, it is instead a bugfix version, which means that it is not experimental, but rather highly recommended.

You should change this wording and turn the checkbox on by default (or better: remove it completely!)

- michael

hi michael!

the current TER2 upload tool in EM uses the same wording:

(*) New development version (latest x.x.x+1)
( ) latest Override this development version (0.6.0)
( ) new_sub New sub version (latest x.x+1.0)

as i want to stay compatible in this i will wait with renaming
until the text in em is changed.

But feel free to fix that during integration into the core.

added patch against typo3 4.2svn.
removed the "show development versions" checkbox. this is the default now.

Does this patch reflect the latest TER update check version? I want to review it the next days.

yes, the patch adds the current ter-version.
only the cli component is missing.

nice. We'll open up a separate patch for including the CLI component. I had a quick look over the patch. I'm gonna do some basic renaming and testing. After that I'm gonna upload it here and send it to the Core list!

Thanks, Christian, for your effort!

Hey christian,

I like your patch extremely!

I made some changes to your patch and uploaded it here.
a) some renaming of variables and function to make them fit in the Croe
b) Fixed one or two bugs (display_files option did not work)
c) Added comments for the functions

I'll send the patch to the core list now.

Who is Christian Ehret?

oh crap, I mixed some patches. I know it's you, Christian Welzel. My bad. I'll fix it.

Great that Christians update_check will be part of core, many thanks to Christian and Bennie!

Tested the patch and it works..

Testing the latest patch I found a minor issue when the md5 values of a new version are not updated, but the order of the files in the md5 sums change:
Then it outputs "A difference between the originally installed version and the current was detected!" even with identical md5 sums. This is eg. true for kickstarter__mvc local version 0.0.6 and server version 0.0.8.
I added a ksort to the md5-arrays to get rid of the misleading information. I also renamed the variables to $serverMD5Array and $currentMD5Array, I think this is more meaningfull.

Attached a new patch in the hope it is usefull.

Hey Christian Kuhn,

thanks for testing, but: Why is a MD5sum not changed when uploading a new version? I mean, at least one file needs to have changed, shouldn't it?

Anyway, I don't like suppressing error messages with @, I suggest we'd do a if stmt around the @ksort. I hope to send the new patch to the ML this week.

I think (please correct me if I am wrong) the md5 sums have to be updated manually and do not get calculated automagically when uploading an ext to ter. So not all devs do this and then the md5 sums stay the same.

The supression with @:
There is a similar one some lines above, so I thought this would be ok. Anyway, a warning will hardly be triggered, only if $EM_CONF[$_EXTKEY]['_md5_values_when_last_written'] is not set at all or is a string or something, A trivial if will be:
if (is_array($currentMD5Array)) ksort($currentMD5Array);

+1 for using if (is_array($currentMD5Array)) ksort($currentMD5Array);

Commited the latest patch (20071030) to 4.2 trunk (rev. 2638)