Feature #17030
closed
Integrate config.pageTitleSeparator
100%
Description
When using config.pageTitleFirst, the title separator ": " is not natural. Title looks like "Page: Site name".
Typo3 should use " - " separator instead, so it will look like "Page - Site name".
Here is the patch:
t3lib/class.t3lib_tstemplate.php:1216
FROM:
return $st.': '.$title;
TO:
return $st . ($titleFirst ? ' - ' : ': ') . $title;
(issue imported from #M5056)
Updated by
Updated by Administrator Admin over 17 years ago
diff available here (I tend to collect "from...to" snippets in patch form):
http://fly.osdn.org.ua/~mike/works/typo3/patches/class.t3lib_tstemplate-pageTitleFirst-5056.patch
It would be reasonable to have these two separators not hardwired but being changeable, too ("|" is what immediately comes to mind).
Updated by Administrator Admin over 17 years ago
Oh, and it's still there in 4.1.1.
Updated by Bernhard Eckl about 13 years ago
- Target version deleted (
0)
Still there in 4.5.6.
I think the best option would be to let it define by Typoscript:
config.pageTitleSeparator = -
Lots of config.noPageTitle = 2 configs would be obsolete then (you finally can really use the internal function).
Updated by Oliver Hader about 13 years ago
- Tracker changed from Bug to Feature
- Subject changed from pageTitleFirst separator to Integrate config.pageTitleSeparator
- Target version set to 4.7.0
- PHP Version set to 5.3
- TYPO3 Version set to 4.6
Updated by Gerrit Code Review almost 13 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7041
Updated by Markus Klein almost 13 years ago
Please read the comments in: http://forge.typo3.org/issues/31319
Updated by Gerrit Code Review almost 13 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7041
Updated by Gerrit Code Review almost 13 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7041
Updated by Gerrit Code Review almost 13 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7041
Updated by Gerrit Code Review almost 13 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7041
Updated by Mario Rimann almost 13 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b5dd11296900c6684a83cf94f7bced5787fc0386.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed