Project

General

Profile

Actions

Feature #17030

closed

Integrate config.pageTitleSeparator

Added by John Angel about 17 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Content Rendering
Target version:
Start date:
2007-02-23
Due date:
% Done:

100%

Estimated time:
PHP Version:
5.3
Tags:
Complexity:
easy
Sprint Focus:

Description

When using config.pageTitleFirst, the title separator ": " is not natural. Title looks like "Page: Site name".

Typo3 should use " - " separator instead, so it will look like "Page - Site name".

Here is the patch:

t3lib/class.t3lib_tstemplate.php:1216

FROM:

return $st.': '.$title;

TO:

return $st . ($titleFirst ? ' - ' : ': ') . $title;

(issue imported from #M5056)


Related issues 1 (0 open1 closed)

Has duplicate TYPO3 Core - Feature #31319: pageTitle separator configurableClosedChris topher2011-10-26

Actions
Actions #1

Updated by John Angel about 17 years ago

Should be fixed for ver 4.1.

Actions #2

Updated by Administrator Admin almost 17 years ago

diff available here (I tend to collect "from...to" snippets in patch form):
http://fly.osdn.org.ua/~mike/works/typo3/patches/class.t3lib_tstemplate-pageTitleFirst-5056.patch

It would be reasonable to have these two separators not hardwired but being changeable, too ("|" is what immediately comes to mind).

Actions #3

Updated by Administrator Admin almost 17 years ago

Oh, and it's still there in 4.1.1.

Actions #4

Updated by Bernhard Eckl over 12 years ago

  • Target version deleted (0)

Still there in 4.5.6.
I think the best option would be to let it define by Typoscript:

config.pageTitleSeparator = -

Lots of config.noPageTitle = 2 configs would be obsolete then (you finally can really use the internal function).

Actions #5

Updated by Oliver Hader over 12 years ago

  • Tracker changed from Bug to Feature
  • Subject changed from pageTitleFirst separator to Integrate config.pageTitleSeparator
  • Target version set to 4.7.0
  • PHP Version set to 5.3
  • TYPO3 Version set to 4.6
Actions #6

Updated by Oliver Hader over 12 years ago

  • Complexity set to easy
Actions #7

Updated by Gerrit Code Review over 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7041

Actions #8

Updated by Markus Klein over 12 years ago

Please read the comments in: http://forge.typo3.org/issues/31319

Actions #9

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7041

Actions #10

Updated by Gerrit Code Review over 12 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7041

Actions #11

Updated by Mario Rimann over 12 years ago

Documentation request is at #32320

Actions #12

Updated by Gerrit Code Review over 12 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7041

Actions #13

Updated by Gerrit Code Review over 12 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7041

Actions #14

Updated by Mario Rimann over 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #15

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF