Project

General

Profile

Actions

Bug #17569

closed

No notification mails will be sent on using user groups

Added by Thomas about 17 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Workspaces
Target version:
-
Start date:
2007-08-30
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.1
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The workspace allows to add
a) users
b) groups
to be members or reviewers of a workspace.

When a WS state changes and t3lib_TCEMain::notifyStageChange() is triggered, the method can hence pass either a list of BE users or groups or both to the method notifyStageChange_getEmails($listOfUsers,$noTablePrefix=FALSE) which only accepts a list of users.

@see line 5895:
The value of $workspaceRec['reviewers'] could also be a list of groups (or mixed groups,users):
$emails = $this->notifyStageChange_getEmails($workspaceRec['reviewers']);

Tested with 4.1.2

(issue imported from #M6239)


Files

0006239.patch (2.62 KB) 0006239.patch Administrator Admin, 2007-12-12 16:32
0006239_v2.patch (2.32 KB) 0006239_v2.patch Administrator Admin, 2008-03-02 22:42
17569.patch (3.82 KB) 17569.patch Benni Mack, 2011-05-12 04:34

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #20557: Notification emails are send to assigned users only, not to groupsClosedBenni Mack2009-06-03

Actions
Actions #1

Updated by Patrick Rodacker almost 17 years ago

added a patch to receive emails for users of the assigned backend usergroups and the assigend users entries.

Actions #2

Updated by Martin Kutschker over 16 years ago

Patrick, there is a problem (because it is confusing) is that $users is used for two distinct data sets: an array of user IDs and a PREF match array.

This can be amened easily:

if (!$noTablePrefix) {
preg_match_all('/be_groups_([0-9]+)/', $listOfEntries, $match_groups);
preg_match_all('/be_users_([0-9]+)/', $listOfEntries, $match_users);
$groups = $match_groups1;
$users = $match_users1;
} else {
$groups = array();
$users = t3lib_BEfunc::trimExplode(',',$listOfEntries,1);
}

Test:

php -r 'preg_match_all("/be_users_([0-9]+)/","be_users_1,be_groups_5,be_users_2",$match);print_r($match);'

Now you have always an array (may be empty) for $users and $groups always containing a list of IDs (without the table prefix).

Please change this as this will make the code much more readable.

Actions #3

Updated by Patrick Rodacker over 16 years ago

Hi Martin,

I have applied the your suggestions and refactored the code a little bit. Please have a look and let me know if this is ok with you.

Recent patch is 0006239_v2.patch

Actions #4

Updated by Matthias Stübner over 15 years ago

see also issue 0011255

Actions #5

Updated by Administrator Admin over 15 years ago

If the patch is already applied ?
It's quite strange to see not applied patch 2 years old.

Actions #6

Updated by Benni Mack over 13 years ago

Attached patch works for TYPO3 4.5.x - sent to review.

Actions #8

Updated by Benni Mack over 13 years ago

  • Status changed from Accepted to Under Review
Actions #9

Updated by Oliver Hader over 13 years ago

  • Subject changed from notifyStageChange() does not send emails, if groups are added to WS members/reviewers to No notification mails will be sent on using user groups
Actions #10

Updated by Mr. Hudson over 13 years ago

Patch set 2 of change I099e6132cd4698b886cae3c837c0cae80c318b46 has been pushed to the review server.
It is available at http://review.typo3.org/2088

Actions #11

Updated by Mr. Hudson over 13 years ago

Patch set 3 of change I099e6132cd4698b886cae3c837c0cae80c318b46 has been pushed to the review server.
It is available at http://review.typo3.org/2088

Actions #12

Updated by Mr. Hudson over 13 years ago

Patch set 4 of change I099e6132cd4698b886cae3c837c0cae80c318b46 has been pushed to the review server.
It is available at http://review.typo3.org/2088

Actions #13

Updated by Tolleiv Nietsch about 13 years ago

  • Target version set to 4.5.6
Actions #14

Updated by Ernesto Baschny over 12 years ago

  • Target version deleted (4.5.6)

Not targeting any specific TYPO3 version yet

Actions #15

Updated by Michael Stucki almost 11 years ago

  • Category set to Workspaces
Actions #16

Updated by Michael Stucki almost 11 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
Actions #17

Updated by Wouter Wolters almost 10 years ago

  • Status changed from Under Review to Closed
  • Is Regression set to No

Benjamin Mack Aug 27 11:41

Abandoned

dropped

Actions

Also available in: Atom PDF