Project

General

Profile

Actions

Bug #18653

closed

top.loadTopMenu undefined

Added by Dan Osipov over 16 years ago. Updated about 11 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2008-04-21
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.2
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

In clickmenu.js there is a function callURL on line 58. If browser is AJAX capable, it runs an ajax request. If not, it calls top.loadTopMenu. However it looks like that function has been completely removed, so the call results in an error. The function is depreciated, however it should still be there, or the call to it has to be removed.

(issue imported from #M8177)


Files

20080519_altclickmenu_deps.patch (6.6 KB) 20080519_altclickmenu_deps.patch Administrator Admin, 2008-05-19 12:34

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #18742: Clean Up The ClickmenuClosedBenni Mack2008-05-04

Actions
Related to TYPO3 Core - Bug #20105: Clickmenu doesn't work with IE8ClosedIngo Renner2009-02-27

Actions
Actions #1

Updated by Patrick Fitz-Simons over 16 years ago

I reconfirm this issue- in 4.2.0 - seems to be related to setting user settings to start up in page module-
if user tools->user settings->startup-> "Start up in the following module" is set to "page module" the clickmenu fails to pop
--repeadedly demonstrated with two discreet admin user accounts
first one is set as default.. (clickmenu works)
the second set to startup in the page module (js error)

firebug reports the following:

top.loadTopMenu is not a function
callURL("table=pages&uid=2&listFr=0&enDisItems=&backPath=|06498ca5b4&addParams=&bank=0")clickmenu.js (line 74)
show("pages", "2", "0", "", "|06498ca5b4", "&bank=0")clickmenu.js (line 47)
showClickmenu("pages", "2", "0", "", "|06498ca5b4", "&bank=0")clickmenu.js (line 218)
onclick(click clientX=0, clientY=0)alt_db_navframe.p... (line 1)
[Break on this error] top.loadTopMenu(this.clickURL + '?' + params);

Actions #2

Updated by Benni Mack over 16 years ago

Yes. the topframe (which was usually empty or the 2nd options were shown) was used to load a page. Due to the restructuring of the Backend, this function was deleted and thus breaks compatibility.

We really need to fix this for 4.2.1. I will take care of this!

Actions #3

Updated by Benni Mack over 16 years ago

I gave this bug some thoughts... and found out that the problem is in a lot of extensions, but mainly because they are written in a wrong way.
I don't want to support this wrong calling.
The problem is that everybody writes its own clickMenu class (originally in alt_clickmenu.php) and does not take the existing interface. If you use the template::wrapItemInClickMenu function you'll always get the latest class.
We already fixed dam_catedit and graytree (along with commerce), please report ANY non-working clickmenu extension for 4.2 here. Thanks a lot.

Maybe I have to update the kickstarter for this, I'll look into it.

Actions #4

Updated by Benni Mack over 16 years ago

I do however agree that this function call to loadTopMenu needs to be removed from clickmenu.js

Actions #5

Updated by Dan Osipov over 16 years ago

Whichever way is better. But your last point is the key - as it stands now, the JS has a bug.

Actions #6

Updated by Stefan Horenkamp over 16 years ago

I have installed version 4.2.1 and i have still an error in the extension dam_catedit Is there any solution for this bug available?

Actions #7

Updated by Benni Mack over 16 years ago

Yes. Install the latest version of dam_catedit from http://typo3xdev.sf.net/

Actions #8

Updated by Stefan Horenkamp over 16 years ago

Thanks a lot for your fast answer. After installing latest version i will get error messages like this:

Fatal error: tx_dam_selBrowseTree::require_once() [function.require]: Failed opening required '/srv/apache2/sekada-daily.de/htdocs/typo3conf/ext/dam_catedit/lib/class.tx_damcatedit_div.php' (include_path='.:/usr/share/php:/usr/share/pear') in /srv/apache2/sekada-daily.de/htdocs/typo3conf/ext/dam/lib/class.tx_dam_selprocbase.php on line 303

and

Unknown column 'sys_language_uid' in 'where clause'
Warning: mysql_fetch_assoc(): supplied argument is not a valid MySQL result resource in /srv/apache2/sekada-daily.de/typo3_src-4.2.1/t3lib/class.t3lib_db.php on line 808

Actions #9

Updated by Philipp Metzler over 15 years ago

The problem still persists in Typo3 4.2.8 if the following is set:

User settings / Edit & Advanced functions / Disable Popup Context Menus

Actions #10

Updated by Gerrit Code Review about 12 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15599

Actions #11

Updated by Gerrit Code Review about 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15599

Actions #12

Updated by Alexander Opitz over 11 years ago

  • Target version deleted (-1)

The gerrit code review is a templavoila issue from Tolleiv and is false here.

The issue is very old, does this issue exists in newer versions of TYPO3 CMS (4.5 or 6.1)?

Actions #13

Updated by Alexander Opitz over 11 years ago

  • Status changed from Under Review to Needs Feedback
Actions #14

Updated by Alexander Opitz about 11 years ago

  • Status changed from Needs Feedback to Closed
  • Assignee deleted (Benni Mack)
  • Is Regression set to No

No feedback for over 90 days.

Actions

Also available in: Atom PDF