Project

General

Profile

Actions

Feature #18885

closed

Do not use htmlspecialchars for CSH description

Added by Uschi Renziehausen about 16 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2008-06-01
Due date:
% Done:

0%

Estimated time:
PHP Version:
5.2
Tags:
Complexity:
Sprint Focus:

Description

Problem:
The CSH node description may contain certain inline elements but runs through htmlcpecialchars() before it gets displayed on hover over a help icon, thus showing the html markup. See the attached 'before' screenshot.

Solution:
The attached patch removes the htmlspecialchars() from the description section in t3lib_befunc::helpText()

Uschi

(issue imported from #M8574)


Files

csh-html-in-description-before.png (4.14 KB) csh-html-in-description-before.png Administrator Admin, 2008-06-01 11:12
csh-html-in-description-after.png (4.28 KB) csh-html-in-description-after.png Administrator Admin, 2008-06-01 11:14
8574-csh-html-in-description.diff (554 Bytes) 8574-csh-html-in-description.diff Administrator Admin, 2008-06-01 11:18

Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Bug #18081: HTML breaks when using special characters in CSH bubbleClosed2008-01-31

Actions
Has duplicate TYPO3 Core - Bug #18609: New popups are HSC-ed in 4.2 RC1ClosedChristian Kuhn2008-04-11

Actions
Has duplicate TYPO3 Core - Bug #20254: HTML tags in help tooltipsClosedChristian Kuhn2009-03-30

Actions
Actions #2

Updated by Benni Mack about 16 years ago

Hey Uschi,

should we close this one as it reverts a patch applied earlier this year? Sounds like reverting work and indeed will be troublesome for tags like <title> etc.

I think the best way to do it would be:
  • Change all CSHs (yeah, will take a LONG time) to use <title> where needed, and use <b> / <i> where needed.
  • Then we apply your patch to the trunk, after all documentation has been updated. What do you think?
Actions #3

Updated by Uschi Renziehausen about 16 years ago

Hey Benni,

can you give me an example where title is needed?

If we are going to update all of CSH, then please let us have real markup at least in the long description (including block elements and images). This would improve readability and usability a lot, because the image would be in the right context.

And now, what do you think :-)

Uschi

Actions #4

Updated by Benni Mack about 16 years ago

Yes, in the hover version, I'd like to have plain (HSCed) text only, in the long description we have a RTE transformation. How the latter will look like, I don't know yet :)

Actions #5

Updated by Uschi Renziehausen over 15 years ago

Dear folks,
can we please have html for csh in 4.3? Real html, I mean? We all know that the screenshots need to be updated but then in quite a few occasions we need to update the texts, either because they refer to the images or because they are simply out of date or not helpful. This is a time consuming job which we do not want to do twice, so having real html first is important.

On forge there is some info about what should be done with csh: http://forge.typo3.org/wiki/hci/New_CSH-System.

Can we please have at least some of it integrated in 4.3? Otherwise we will not have an updated csh even in 4.4.

Uschi

Actions #6

Updated by Uschi Renziehausen over 15 years ago

Again: Is that feasible for 4.3?

Actions #7

Updated by Xavier Perseguers over 12 years ago

  • Assignee deleted (Steffen Kamper)
  • Target version deleted (0)
Actions #8

Updated by Alexander Opitz about 11 years ago

  • Status changed from Accepted to Needs Feedback

The issue is very old, does this issue exists in newer versions of TYPO3 CMS (4.5 or 6.1)?

Actions #9

Updated by Alexander Opitz almost 11 years ago

  • Status changed from Needs Feedback to Closed

No feedback for over 90 days.

Actions

Also available in: Atom PDF