Project

General

Profile

Actions

Feature #19163

open

Automatically execute nested USER_INT/COA_INT objects as regular USER/COA objects

Added by Oliver Hader over 16 years ago. Updated almost 2 years ago.

Status:
Under Review
Priority:
Should have
Assignee:
Category:
TypoScript
Start date:
2008-07-28
Due date:
% Done:

0%

Estimated time:
PHP Version:
5.2
Tags:
Complexity:
Sprint Focus:

Description

Imagine you have the following situation in TypoScript:
10 = COA_INT
10 {
10 = COA_INT
10 {
10 = COA_INT
10 {
10 = TEXT
10.value = Test
}
}
}
The nestification of the COA_INT objects would result in recursing calls for each new level of that *_INT object. However, for the first occurence of COA_INT the caching for that object and nested objects is already disabled - thus it's not required to perform this task again.

(issue imported from #M9065)


Files

0009065.patch (2.17 KB) 0009065.patch Administrator Admin, 2008-07-28 15:42
Actions #1

Updated by Andreas over 16 years ago

this is bad typoscript programming. nobody should programming like this.

correct way:

10 = COA_INT
10 {
10 = COA
10 {
10 = COA
10 {
10 = TEXT
10.value = Test
}
}
}

Actions #2

Updated by Oliver Hader over 16 years ago

Ooooh yeah! Absolutely right, it should not. But it defintively happens! So, any more constructive feedback?!
And by the way... the attached patch is exactly doing what you did manually...

Actions #3

Updated by Oliver Hader over 16 years ago

To justify this issue, imagine you get an extension from TER that sets up the following TypoScript:
plugin.tx_myext_pi1 = USER_INT
plugin.tx_myext_pi1 {
...
}

And then you'd just put it somewhere to your page, inside a COA_INT like this:
page = PAGE
page.10 = COA_INT
page.10.10 =< plugin.tx_myext_pi1

Here we go... and there are more variants how this easily could happen...

Actions #4

Updated by Andreas over 16 years ago

Ok, now i've got it :)

Actions #5

Updated by Alexander Opitz over 11 years ago

  • Category deleted (Communication)
  • Status changed from Accepted to Needs Feedback
  • Target version deleted (0)

As this report is very old, is the handling in newer TYPO3 CMS Versions (like 6.0/6.1) more like you expect it?

Actions #6

Updated by Oliver Hader over 11 years ago

The handling is still the same in TYPO3 CMS 6.x.

Actions #7

Updated by Oliver Hader over 11 years ago

  • Status changed from Needs Feedback to On Hold
Actions #8

Updated by Mathias Schreiber almost 10 years ago

  • Target version set to 7.2 (Frontend)
Actions #9

Updated by Benni Mack over 9 years ago

  • Target version changed from 7.2 (Frontend) to 7.4 (Backend)
Actions #10

Updated by Susanne Moog over 9 years ago

  • Target version changed from 7.4 (Backend) to 7.5
Actions #11

Updated by Benni Mack about 9 years ago

  • Target version changed from 7.5 to 8 LTS
Actions #12

Updated by Riccardo De Contardi almost 8 years ago

  • Target version changed from 8 LTS to 9.0
Actions #13

Updated by Benni Mack about 7 years ago

  • Status changed from On Hold to Needs Feedback

So how about pushing your idea to gerrit and add tests to that?

Actions #14

Updated by Susanne Moog about 7 years ago

  • Category set to TypoScript
Actions #15

Updated by Susanne Moog almost 7 years ago

  • Target version changed from 9.0 to Candidate for Major Version
Actions #16

Updated by Benni Mack over 4 years ago

  • Status changed from Needs Feedback to Rejected

Won't do. This is a nice to have one, but definitively makes the complexity higher. Instead, let's treat each USER/COA as a cached response and use that one instead.

Actions #17

Updated by Benni Mack over 4 years ago

  • Status changed from Rejected to Accepted
Actions #18

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77841

Actions #19

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77841

Actions

Also available in: Atom PDF