Project

General

Profile

Actions

Bug #20637

closed

Remove ancient blurLink code

Added by Michiel Roos over 15 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2009-06-21
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I know I can use config.removeDefaultJS, but that will also kill my spam protection rules.

The only way I can get around this is by making my own JS file for the email spam protection JS and then setting config.removeDefaultJS to 1

I think the time has come to give the blurLink code and other default JS code an overhaul.

At least make the blurLink code more configurable. Like not including it when config.noBlur = 1

The best would be to get rid of it completely and only putting it back when config.iCanHazBlurCode = 1

??

(issue imported from #M11367)


Files

11367.diff (834 Bytes) 11367.diff Administrator Admin, 2009-06-30 18:40
noblur.patch (2.59 KB) noblur.patch Administrator Admin, 2010-09-29 15:58

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #35827: Remove noBlur codeClosed2012-04-10

Actions
Actions #1

Updated by Steffen Kamper over 15 years ago

attached patch allows

config.noBlur = 1

to get rid of the
// Blurring links:
function blurLink(theObject) { //
if (msie4) {theObject.blur();}
}

Actions #2

Updated by Steffen Müller over 15 years ago

Good idea!

What about the second part of the patch? I don't see a reason for a closing bracket. Bug?
- ' . $JSef0;
+ ') . $JSef0;

Actions #3

Updated by Steffen Kamper over 15 years ago

no, that's part of the condition :)

But that's not enough. Also the link generation should be aware of this config, which makes it more complex. I will look at this now.

Actions #4

Updated by Sascha Egerer over 14 years ago

Any news here?
This blurLink stuff sucks... still in version TYPO3 4.4

Actions #5

Updated by Thomas Deinhamer over 14 years ago

Yeah, I think that function is not needed anymore. Far away from beeing state of the art.

Actions #6

Updated by Benni Mack about 14 years ago

Attached is a patch that removes the whole functionality, because this should not be done at all with inline JS.

Actions #7

Updated by Xavier Perseguers almost 13 years ago

  • Category deleted (Communication)
  • Assignee deleted (Steffen Kamper)
  • Target version deleted (0)
Actions #8

Updated by Mario Rimann about 12 years ago

Not sure if it's our configuration - but I guess this one is resolved since 4.7.x where a lot of stuff has been improved regarding the whole frontend output generation. At least I cannot see anything regarding blur in our whole FE output.

Can someone confirm my guess and close this issue if I'm right?

Actions #9

Updated by Alexander Opitz over 11 years ago

  • Status changed from Accepted to Closed

Closed as commented.

Actions

Also available in: Atom PDF