No FE editing with only field edit icons and with "old" feedit extension
I was unable to make FE editing work with this UserTS setup :
edit = 1
hide = 1
displayFieldIcons = 1
displayIcons = 0
Setting displayIcons = 1 does the trick however this enable features I don't need.
It seems there is an issue with the test function isFrontendEditingActive which is testing only if $GLOBALS['TSFE']->displayEditIcons 1 but not if $GLOBALS['TSFE']->displayFieldEditIcons 1.
A simple patch is attached.
Many thanks for your review
(issue imported from #M13978)
#2 Updated by Fedir RYKHTIK over 8 years ago
2 Daniel Mueller
No. It's seems to be an another problem. Existing verification is not complete, it checks only the case when edit icons are rendered aside content records, and not the case when edit icons are rendered aside individual fields of content.
So the proposed patch should resolve the bug. I've made a little bit more clean version of the patch. Check in the attachment.
#3 Updated by Loek Hilgersom over 8 years ago
Just ran into the same issue, summarized:
for non-admin be-users, you cannot enable admin panel displayFieldIcons without also enabling displayIcons.
The problem still exists with v4.4 and 4.5
The second patch, 13978-2.patch, is clean and working for TYPO3 v4.5.0
+1 by reading and testing, should be a no-brainer.
#10 Updated by Sybille Peters over 1 year ago
Thank you for your report.
Even though it has been some time, would you consider checking if your patch idea is still up to date and upload it to our Gerrit review server?
Someone could do this for you, but I am thinking you might like the opportunity to contribute to TYPO3 yourself.
You can find a description of the TYPO3 contribution workflow here: https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/
Hint: If you get stuck anywhere, ask on Slack in the #typo3-cms-coredev channel. You can register in the TYPO3 slack workspace here: https://forger.typo3.com/slack
Thank you in advance!