Project

General

Profile

Actions

Bug #22710

closed

tslib_fe::getPagesTSconfig wrong order of rootline TS

Added by Martin Neumann over 14 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2010-05-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
5.0
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Stabilization Sprint

Description

If you set some pageTSConfig on a higher level page in the rootline and overwrite that value in a lower level page the value from the HIGHER level will be delivered by tslib_fe::getPagesTSconfig if you call that method on the lower-level page.

Correct would be to deliver the value from the lower level page. This is done perfectly in the corresponding method t3lib_befunc::getPagesTSconfig for the BE.

The little difference: t3lib_befunc::getPagesTSconfig has the additional line 1334: ksort($rootLine); // Order correctly
which re-sorts the rootline. This line has to be inserted into tslib_fe::getPagesTSconfig also as line 4440 somethin like:

$rootLine=$this->rootLine;
ksort($rootLine);
//while(list($k,$v)=each($this->rootLine)) {
while(list($k,$v)=each($rootLine)) {

(issue imported from #M14471)


Files

pagetsconfig_1.0.0_201507281954.zip (2.3 KB) pagetsconfig_1.0.0_201507281954.zip Extension for reproducing the issue Daniel Goerz, 2015-07-28 19:59
Actions #1

Updated by Sven Burkert over 11 years ago

  • Target version deleted (0)

Thank you, patch works for me.

Actions #2

Updated by Sven Burkert over 11 years ago

  • Target version set to 4.5.24

TYPO3 Version 4.5.23 is also affected by this bug.

Actions #3

Updated by Michael Stucki over 11 years ago

  • Status changed from New to Accepted
Actions #4

Updated by Mathias Schreiber almost 10 years ago

  • Target version changed from 4.5.24 to 7.1 (Cleanup)
  • Is Regression set to No
Actions #5

Updated by Benni Mack over 9 years ago

  • Target version changed from 7.1 (Cleanup) to 7.4 (Backend)
Actions #6

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41798

Actions #7

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41798

Actions #8

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41798

Actions #9

Updated by Daniel Goerz over 9 years ago

Steps to reproduce:

1. Install EXT:pagetsconfig
2. Create a new PageTree wit at least two levels.
3. Create a new root TypoScript Template record on the root page of the new tree.
4. Remove the autogenerated lines from setup.
5. Include the static template of EXT:pagetsconfig
6. Set the PageTSConfig key "test" to something different in the settings of each page of the tree (Resources tab).
7. View the output in the view module or the frontend.

Actions #10

Updated by Daniel Goerz over 9 years ago

  • Target version changed from 7.4 (Backend) to 7.5
Actions #11

Updated by Daniel Goerz over 9 years ago

  • Target version changed from 7.5 to 7.4 (Backend)
  • Sprint Focus set to Stabilization Sprint
Actions #12

Updated by Daniel Goerz over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF