Project

General

Profile

Actions

Bug #23864

closed

TCEFORM.tt_content.CType.keepItems = textpic does not work.

Added by taywa gmbh over 13 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2010-10-28
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.4
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

TCEFORM.tt_content.CType.keepItems = textpic

Does not work, there is no CType to choose in the BE

This should have the same effect like:

TCEFORM.tt_content.CType.removeItems = header, text, image, bullets, table, uploads, multimedia, mailform, search, login, splash, menu, shortcut, list, script, div, html

(not removing textpic)

(issue imported from #M16160)


Files

keepItems1.png (60.6 KB) keepItems1.png Administrator Admin, 2010-11-02 15:28
keepItems2.png (19.3 KB) keepItems2.png Administrator Admin, 2010-11-02 15:28
keepItems3.png (22 KB) keepItems3.png Administrator Admin, 2010-11-02 15:29

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #62133: Contentelement Wizard and TSConfig misbehaviourClosed2014-10-09

Actions
Related to TYPO3 Core - Bug #61114: „TCEFORM.tt_content.menu_type.removeItems = 0“ removes the whole „Special Menus“ entry from the new content element wizardClosedGöran Bodenschatz2014-08-21

Actions
Actions #1

Updated by taywa gmbh over 13 years ago

Sorry, I mean:

This SHOULT have the same effect like:

TCEFORM.tt_content.CType.removeItems = header, text, image, bullets, table, uploads, multimedia, mailform, search, login, splash, menu, shortcut, list, script, div, html

Actions #2

Updated by Jo Hasenau over 13 years ago

Where did you find a property named "keepItems"?
AFAICS there is none, so of course this doesn't work.

Or did you want to make it a feature request?
Then it can't be done for 4.4 though.

Actions #3

Updated by Jo Hasenau over 13 years ago

Sorry - just found out that I was checking the wrong version of the TSconfig manual.

Tested it and for me it works as expected: The selectbox of the tt_content editing form contains "textpic" only.

Actions #4

Updated by Chris topher over 13 years ago

I fixed the description.

Actions #5

Updated by Jo Hasenau over 13 years ago

still can't reproduce

Actions #6

Updated by taywa gmbh over 13 years ago

In the wizard textpic doesen't show up, in the selectbox it shows up. Maybe its a Problem with the wizard?

Look at the pictures

Actions #7

Updated by Joschi Kuphal over 11 years ago

  • Target version deleted (0)

The problem still exists today (TYPO3 4.7.4) and definitely is a problem with the (classical) "New content wizard" only (the TemplaVoila wizard is not affected though). I could track it down to the following reason:

For each registered wizard item (mod.wizards.newContentElement.wizardItems.xxx.elements.xxx) the wizard checks for each given tt_content default value (tt_content_defValues.xxx) if the value part is present in the keepItems list. Now imagine the wizard definition of the "textpic" item (PHP representation):

array(
    [icon] => gfx/c_wiz/text_image_right.gif
    [title] => Text und Bilder
    [description] => Eine beliebige Anzahl von Bildern mit umfließendem Text.
    [tt_content_defValues] => Array
        (
            [CType] => textpic
            [imageorient] => 17
        )

)

Given the above, the wizard does not only check if the (CType value) "textpic" is contained in the keepItems list, but also looks for the number "17" (default value for the "imageorient" property).

The short term solution is to simply add "17" to the keepItems list:

TCEFORM.tt_content.CType.keepItems = textpic,17

The wizard will then show the "textpic" element as expected. Similar would have to be done for any other default value defined for any wizard item you want to be shown.

Of course this is not a valid long term solution and could also lead to unexpected side effects. At long sight the wizard has to be patched to only check for the CType default value, which would be pretty easy and straightforward.

Actions #8

Updated by Marco Huber over 11 years ago

I can reproduce this bug in a TYPO3 4.5 installation.

Actions #9

Updated by Ludwig Rafelsberger about 10 years ago

The problem still persists in the current master (6.2-dev)

As stated before, the validity checks are (correctly) executed with each key in tt_content_defValues, but (wrongly) always against the allowed values of CType.

Will come up with a patch soon.

Actions #10

Updated by Gerrit Code Review about 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27588

Actions #11

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27588

Actions #12

Updated by Gerrit Code Review about 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27588

Actions #13

Updated by Gerrit Code Review about 10 years ago

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28307

Actions #14

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28307

Actions #15

Updated by Ludwig Rafelsberger about 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #16

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF