Bug #24186
closedHTMLparser - fixAttrib.['class'].list does not assign first element, when attribute value not in list
100%
Description
I have the following configuration:
lib.parseFunc_RTE.externalBlocks.table.stdWrap.HTMLparser.tags.table.fixAttrib.class.list = contenttable, sofa1, sofa2, sofa3, sofa4
When a table has a class not in the list above, the result is not 'contenttable' as expected, but an empty class.
In class.t3lib_parsehtml.php line 827 the current code is:
if (count($newClasses)) {
$tagAttrib0[$attr] = implode(' ', $newClasses);
} else {
$tagAttrib0[$attr] = '';
}
I think that has to be:
if (count($newClasses)) {
$tagAttrib0[$attr] = implode(' ', $newClasses);
} else {
$tagAttrib0[$attr]=$params['list'][0];
}
(issue imported from #M16542)
Updated by Alexander Opitz about 10 years ago
- Status changed from New to Needs Feedback
- Target version deleted (
0) - Is Regression set to No
Hi,
as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (4.5 or 6.1)?
Updated by Christian Kuhn over 9 years ago
imho still valid, had this too on a 4.5 instance.
Updated by Alexander Opitz over 9 years ago
- Status changed from Needs Feedback to New
Updated by Riccardo De Contardi over 8 years ago
- TYPO3 Version changed from 4.4 to 6.2
Updated by Gerrit Code Review over 8 years ago
- Status changed from New to Under Review
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39349
Updated by Gerrit Code Review over 8 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39349
Updated by Gerrit Code Review over 8 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39349
Updated by Gerrit Code Review over 8 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39349
Updated by Gerrit Code Review over 8 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39349
Updated by Frederic Gaus over 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b34b66bebcbd63bac77a34c8e086ed0a47ed49bf.