Project

General

Profile

Actions

Bug #25704

closed

Use consistent class names

Added by Susanne Moog about 13 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Should have
Category:
Workspaces
Target version:
Start date:
2011-04-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Could we decide for either Tx or tx and not use both?

Tx_Workspaces_Controller_AbstractController
Tx_Workspaces_Controller_PreviewController
Tx_Workspaces_Controller_ReviewController
tx_Workspaces_ExtDirect_ActionHandler
tx_Workspaces_ExtDirect_MassActionHandler
tx_Workspaces_ExtDirect_Server
tx_Workspaces_ExtDirect_ToolbarMenu
Tx_Workspaces_Reports_StatusProvider
tx_Workspaces_Service_AutoPublish
tx_Workspaces_Service_AutoPublishTask
tx_Workspaces_Service_Befunc
tx_Workspaces_Service_Fehooks
tx_Workspaces_Service_GridData
Tx_Workspaces_Service_Stages
tx_Workspaces_Service_Tcemain
tx_Workspaces_Service_Workspaces
tx_Workspaces_Service_WorkspacesTest


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #22594: Class prefix problem in getUserObj and callUserFunction (t3lib_div)Closed2010-05-05

Actions
Actions #1

Updated by Andreas Kiessling about 13 years ago

I think it depends on where the class is instantiated.

E.g. tx_Workspaces_Service_Fehooks is set as Hook for $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['hook_eofe']['workspaces']
-> t3lib_div::callUserFunction($_funcRef,$_params,$this);
which checks if the class is prefixed with user_ or tx_

Have a look at RFC #M14313 in the core list with some discussion and patches for the tx_ vs Tx_ situation

Actions #2

Updated by Georg Ringer almost 13 years ago

Tx_ can be used now, so Tx_ is IMO now the correct CGL for extbase extensions

Actions #3

Updated by Tolleiv Nietsch almost 13 years ago

  • TYPO3 Version set to 4.6
Actions #4

Updated by Tolleiv Nietsch almost 13 years ago

  • Status changed from New to Accepted
Actions #5

Updated by Mr. Hudson over 12 years ago

Patch set 1 of change I6049923420414303c3985b6ff96a80ec1be9ef7f has been pushed to the review server.
It is available at http://review.typo3.org/4466

Actions #6

Updated by Tolleiv Nietsch over 12 years ago

  • Status changed from Accepted to Under Review

patch pending in review - TBD whether it's fine to rename classes without deprecation - imho it is.

Actions #7

Updated by Tolleiv Nietsch over 12 years ago

  • Target version set to 4.6.0-beta2
Actions #8

Updated by Tolleiv Nietsch over 12 years ago

  • Assignee set to Tolleiv Nietsch
Actions #9

Updated by Mr. Hudson over 12 years ago

Patch set 2 of change I6049923420414303c3985b6ff96a80ec1be9ef7f has been pushed to the review server.
It is available at http://review.typo3.org/4466

Actions #10

Updated by Tolleiv Nietsch over 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:f6df0e62f1bd6dd6f70162c60a8ce47dfc197bb7.

Actions #11

Updated by Xavier Perseguers about 12 years ago

  • Status changed from Resolved to Closed
Actions #12

Updated by Michael Stucki over 10 years ago

  • Category set to Workspaces
Actions #13

Updated by Michael Stucki over 10 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
Actions

Also available in: Atom PDF