Bug #27310
closed
Space missing in popup window
100%
Description
Only a small thing: in the popup window where you can send notifications to other users about change of state, a space character is missing.
In Classes\ExtDirect\ActionHandler.php this line
'html' => $GLOBALS['LANG']->sL('LLL:EXT:workspaces/Resources/Private/Language/locallang.xml:window.sendToNextStageWindow.itemsWillBeSentTo') . $stageTitle,
needs to be somthing like this
'html' => $GLOBALS['LANG']->sL('LLL:EXT:workspaces/Resources/Private/Language/locallang.xml:window.sendToNextStageWindow.itemsWillBeSentTo') .' '.$stageTitle,
The german language string for window.sendToNextStageWindow.itemsWillBeSentTo in fact has a space character at the end, but as far as I can see, there is a trim() done in function sL(), so this is cut off.
Updated by Markus Klein over 13 years ago
Hi!
Can you provide a patch and push it to review.typo3.org?
More info here: http://wiki.typo3.org/Contribution_Walkthrough_Tutorials
Updated by Michael Klapper over 13 years ago
I checked this issue in the EXT:workspaces/Resources/Private/Language/locallang.xml (default language) there is an additional whitespace at the end of the label wich works fine.
Next, i load the german translation for the backend and checked that issue again - know the described issue occurs. The reason is a missing whitespace in the label of germany translation file.
File: l10n/de/workspaces/Resources/Private/Language/de.locallang.xml
<label index="window.sendToNextStageWindow.itemsWillBeSentTo">Das/die ausgewählte(n) Elemente(n) wird gesetzt auf Stufe</label>
Updated by Markus Klein over 13 years ago
So this is strange: dermueller says he has a space at the end and this issue occurs and Michael says the is no space and that's why this issue occurs.
@dermueller no-lastname-given:
I can't find any trim() in sL(). Which line do you mean?
Which TYPO3 version are you exactly working on?
Can both of you please update to the latest version of the translation and check this issue again.
Thanks.
Updated by Michael Klapper over 13 years ago
- Status changed from New to Accepted
- Assignee set to Michael Klapper
Updated by Markus Klein over 13 years ago
Hi Michael,
in this case I'd suggest you set the Status to "Needs Feedback" rather than "Accepted".
Updated by Michael Klapper over 13 years ago
No "Accepted" is fine, i discussed that issue and will change the default behavior so that we get the required space.
Updated by Mr. Hudson over 13 years ago
Patch set 1 of change I2b46e13136cea7f142fbed113fb250a7bd952973 has been pushed to the review server.
It is available at http://review.typo3.org/2875
Updated by Mr. Hudson over 13 years ago
Patch set 1 of change Ie0cd46baa07c3d7bdb80c97fc53432eacba276d9 has been pushed to the review server.
It is available at http://review.typo3.org/2876
Updated by Michael Klapper over 13 years ago
- Status changed from Accepted to Under Review
Updated by Michael Klapper over 13 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset commit:07a3238256d3ac11b417262dd8448783638b297c.
Updated by Michael Stucki almost 11 years ago
- Project changed from 624 to TYPO3 Core
- Category changed from Workspaces to Workspaces
Updated by