Bug #27310
closed
Space missing in popup window
Added by dermueller no-lastname-given over 13 years ago.
Updated about 6 years ago.
Description
Only a small thing: in the popup window where you can send notifications to other users about change of state, a space character is missing.
In Classes\ExtDirect\ActionHandler.php this line
'html' => $GLOBALS['LANG']->sL('LLL:EXT:workspaces/Resources/Private/Language/locallang.xml:window.sendToNextStageWindow.itemsWillBeSentTo') . $stageTitle,
needs to be somthing like this
'html' => $GLOBALS['LANG']->sL('LLL:EXT:workspaces/Resources/Private/Language/locallang.xml:window.sendToNextStageWindow.itemsWillBeSentTo') .' '.$stageTitle,
The german language string for window.sendToNextStageWindow.itemsWillBeSentTo in fact has a space character at the end, but as far as I can see, there is a trim() done in function sL(), so this is cut off.
I checked this issue in the EXT:workspaces/Resources/Private/Language/locallang.xml (default language) there is an additional whitespace at the end of the label wich works fine.
Next, i load the german translation for the backend and checked that issue again - know the described issue occurs. The reason is a missing whitespace in the label of germany translation file.
File: l10n/de/workspaces/Resources/Private/Language/de.locallang.xml
<label index="window.sendToNextStageWindow.itemsWillBeSentTo">Das/die ausgewählte(n) Elemente(n) wird gesetzt auf Stufe</label>
So this is strange: dermueller says he has a space at the end and this issue occurs and Michael says the is no space and that's why this issue occurs.
@dermueller no-lastname-given:
I can't find any trim() in sL(). Which line do you mean?
Which TYPO3 version are you exactly working on?
Can both of you please update to the latest version of the translation and check this issue again.
Thanks.
- Status changed from New to Accepted
- Assignee set to Michael Klapper
Hi Michael,
in this case I'd suggest you set the Status to "Needs Feedback" rather than "Accepted".
No "Accepted" is fine, i discussed that issue and will change the default behavior so that we get the required space.
Patch set 1 of change I2b46e13136cea7f142fbed113fb250a7bd952973 has been pushed to the review server.
It is available at http://review.typo3.org/2875
Patch set 1 of change Ie0cd46baa07c3d7bdb80c97fc53432eacba276d9 has been pushed to the review server.
It is available at http://review.typo3.org/2876
- Status changed from Accepted to Under Review
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset commit:07a3238256d3ac11b417262dd8448783638b297c.
- Category set to Workspaces
- Project changed from 624 to TYPO3 Core
- Category changed from Workspaces to Workspaces
- Status changed from Resolved to Closed
Also available in: Atom
PDF