Project

General

Profile

Actions

Bug #28220

closed

Preview with preview button not possible since 49d8f25 (page, list and template module)

Added by Philipp Gampe over 12 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2011-07-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

It seems that 49d8f25 ("[FEATURE] Show info if staged element is edited") caused a regression.

After that revision it is not possible any more to click on the preview icon in the mentioned modules.
Web-View does work although.

The source looks pretty complete, so I guess there is just a JS error:

mod.php:283 Uncaught SyntaxError: Unexpected token ILLEGAL
preview.js:68 Uncaught TypeError: Cannot read property 'Workspaces' of undefined

Looking at the mentioned lines:

/*workspaces.preview.lll*/
TYPO3.LLL.Workspaces = {
            visualPreview: 'Visual preview',
            listView: 'List view',
            livePreview: 'Live',
            livePreviewDetail: 'Click this element to hide the workspace version and see the live version of the
mod.php:283 Uncaught SyntaxError: Unexpected token ILLEGAL
                    page.
                ',
            workspacePreview: 'Workspace',
            workspacePreviewDetail: 'Click this element to hide the live version and see the workspace version of the
                    page.
                ',
            modeSlider: 'Slider',
            modeVbox: 'Vertical',
            modeHbox: 'Horizontal'
        };

The second only is of course only a result of the first problem.

xtype: 'button',
                                    id: 'sizeSliderButtonLive',
                                    cls: 'sliderButton',
                                    text: TYPO3.LLL.Workspaces.livePreview,
preview.js:68 Uncaught TypeError: Cannot read property 'Workspaces' of undefined
                                    tooltip: TYPO3.LLL.Workspaces.livePreviewDetail,
                                    width: 100,
                                    listeners: {
                                        click: {
                                            fn: function () {
                                                Ext.getCmp('sizeSlider').setValue(0);
                                            }
                                        }
                                    }


Related issues 1 (0 open1 closed)

Has duplicate TYPO3 Core - Bug #28280: Line breaks in XLF translation causes JS errorClosed2011-07-18

Actions
Actions #1

Updated by Philipp Gampe over 12 years ago

Ok, I found the reason: the file Resources/Private/Language/locallang.xlf contains linebreaks after 120 chars. If those occur inside a label like in preview.livePreviewDetail and preview.workspacePreviewDetail the break and the tabs seems to corrupt the JS file.

Actions #2

Updated by Michael Klapper over 12 years ago

  • Status changed from New to Needs Feedback
Actions #3

Updated by Tolleiv Nietsch over 12 years ago

  • Status changed from Needs Feedback to Accepted

Confirmed

Actions #4

Updated by Mr. Hudson over 12 years ago

Patch set 1 of change I668f92ce97d9d3f4c95c17aeb470a753e96cb769 has been pushed to the review server.
It is available at http://review.typo3.org/3374

Actions #5

Updated by Tolleiv Nietsch over 12 years ago

  • Status changed from Accepted to Under Review
Actions #6

Updated by Tolleiv Nietsch over 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:edcc5ab5515f02b5eb036a6df0afbb2541d7114e.

Actions #7

Updated by Michael Stucki over 10 years ago

  • Category set to Workspaces
Actions #8

Updated by Michael Stucki over 10 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
Actions #9

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF