Bug #28220
closedPreview with preview button not possible since 49d8f25 (page, list and template module)
100%
Description
It seems that 49d8f25 ("[FEATURE] Show info if staged element is edited") caused a regression.
After that revision it is not possible any more to click on the preview icon in the mentioned modules.
Web-View does work although.
The source looks pretty complete, so I guess there is just a JS error:
mod.php:283 Uncaught SyntaxError: Unexpected token ILLEGAL
preview.js:68 Uncaught TypeError: Cannot read property 'Workspaces' of undefined
Looking at the mentioned lines:
/*workspaces.preview.lll*/
TYPO3.LLL.Workspaces = {
visualPreview: 'Visual preview',
listView: 'List view',
livePreview: 'Live',
livePreviewDetail: 'Click this element to hide the workspace version and see the live version of the
mod.php:283 Uncaught SyntaxError: Unexpected token ILLEGAL
page.
',
workspacePreview: 'Workspace',
workspacePreviewDetail: 'Click this element to hide the live version and see the workspace version of the
page.
',
modeSlider: 'Slider',
modeVbox: 'Vertical',
modeHbox: 'Horizontal'
};
The second only is of course only a result of the first problem.
xtype: 'button',
id: 'sizeSliderButtonLive',
cls: 'sliderButton',
text: TYPO3.LLL.Workspaces.livePreview,
preview.js:68 Uncaught TypeError: Cannot read property 'Workspaces' of undefined
tooltip: TYPO3.LLL.Workspaces.livePreviewDetail,
width: 100,
listeners: {
click: {
fn: function () {
Ext.getCmp('sizeSlider').setValue(0);
}
}
}
Updated by Philipp Gampe over 13 years ago
Ok, I found the reason: the file Resources/Private/Language/locallang.xlf
contains linebreaks after 120 chars. If those occur inside a label like in preview.livePreviewDetail
and preview.workspacePreviewDetail
the break and the tabs seems to corrupt the JS file.
Updated by Michael Klapper over 13 years ago
- Status changed from New to Needs Feedback
Updated by Tolleiv Nietsch over 13 years ago
- Status changed from Needs Feedback to Accepted
Confirmed
Updated by Mr. Hudson over 13 years ago
Patch set 1 of change I668f92ce97d9d3f4c95c17aeb470a753e96cb769 has been pushed to the review server.
It is available at http://review.typo3.org/3374
Updated by Tolleiv Nietsch over 13 years ago
- Status changed from Accepted to Under Review
Updated by Tolleiv Nietsch over 13 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset commit:edcc5ab5515f02b5eb036a6df0afbb2541d7114e.
Updated by Michael Stucki almost 11 years ago
- Project changed from 624 to TYPO3 Core
- Category changed from Workspaces to Workspaces