Project

General

Profile

Actions

Bug #28280

closed

Line breaks in XLF translation causes JS error

Added by Björn Pedersen over 13 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Miscellaneous
Target version:
-
Start date:
2011-07-18
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
Tags:
Complexity:
medium
Is Regression:
No
Sprint Focus:

Description

The xlf files for workspace contain some line breaks (livePreviewDetail). This causes a JS error.

unterminated string literal
livePreviewDetail: 'Click this elem...rsion and see the live version of the

The generated JS:
TYPO3.LLL.Workspaces = {
visualPreview: 'Visual preview',
listView: 'List view',
livePreview: 'Live',
livePreviewDetail: 'Click this element to hide the workspace version and see the live version of the
page.
',
...


Related issues 1 (0 open1 closed)

Is duplicate of TYPO3 Core - Bug #28220: Preview with preview button not possible since 49d8f25 (page, list and template module)Closed2011-07-15

Actions
Actions #1

Updated by Susanne Moog over 13 years ago

  • Status changed from New to Closed

Closed as duplicate (and already fixed in workspace trunk)

Actions #2

Updated by Björn Pedersen over 13 years ago

In my opinion the fix in WS is only partial: it relies on the formatting of the file.

A better fix would be in the XLIFF part to remove linebreaks outside of [!CDATA[... ]] parts in general.

Actions #3

Updated by Susanne Moog over 13 years ago

I'll have another look later today, especially at how it was done in the pre-xlf century ;)

Actions #4

Updated by Xavier Perseguers over 13 years ago

  • Subject changed from Line breaks in xlf trasnslation casue js error to Line breaks in XLF translation causes JS error
Actions #5

Updated by Björn Pedersen over 13 years ago

  • Status changed from Closed to New

Re-openend for more discussion.

Actions #6

Updated by Tolleiv Nietsch over 13 years ago

  • Complexity set to medium

@Susanne - good chance this only showed up because of the workaround of the workspaces preview-module which is required because we open a module outside of the normally surrounding backend panels.

Actions #7

Updated by Björn Pedersen over 13 years ago

I have to update my comment even more:
line breaks are not allowed in JS strings, so line breaks from the xlf-files and xml-files should never propagate unescaped to the javascript.

Actions #8

Updated by Björn Pedersen about 13 years ago

Testing some of the multi line strings in locallang_core.xlf, it seems this one has been fixed (git master as of today).

Actions #9

Updated by Alexander Opitz almost 10 years ago

  • Status changed from New to Needs Feedback
  • Is Regression set to No

Hi,

as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (6.2.7)?

Actions #10

Updated by Alexander Opitz over 9 years ago

  • Status changed from Needs Feedback to Closed

No feedback within the last 90 days => closing this issue.

If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.

Actions

Also available in: Atom PDF