Bug #30892
closedt3lib_befunc::getViewDomain returns wrong or no domain
100%
Description
Issue 1:
If the TYPO3 BE hostname is not configured as a sys_domain record t3lib_befunc::getViewDomain will always return TYPO3 BE hostname and not the first domain of the root line of the page which is being previewed.
Issue 2:
If the TYPO3 BE hostname is configured as a sys_domain but the current root line does not contain a valid domain record t3lib_befunc::getViewDomain will return only 'http://' ie. no domain. I would think the logical thing would be to return the TYPO3 BE hostname.
Files
Updated by Jaume Prat about 13 years ago
- File class.t3lib_befunc.diff class.t3lib_befunc.diff added
I have a similar problem with my TYPO3 project. I needed to fix the class t3lib_befunc in core.
I'm looking forward to your feedback.
Updated by Jaume Prat about 13 years ago
- File t3lib_befunc.diff t3lib_befunc.diff added
- Assignee set to TYPO3 Release Team
- Target version set to 4.6.1
This patch is the correct and solves the problem. Please ignore the last one
Updated by Jaume Prat about 13 years ago
Steps To Reproduce this issue:
With a multidomain Webpage(s) in one TYPO3-Instance:
- add more than 1 domain in your Rootpage, for example:
- put domain1 at the first position
- in Backend with domain2 (www.domain2.com/typo3) try to preview a page.
You will be always redirect to domain1 (!)
With this patch you will be redirect to domain2 if you try to preview a page with domain2 and search if domain2 exist in your rootline.
Could anybody try this patch?
THX!
Updated by Mr. Jenkins about 13 years ago
- Status changed from New to Under Review
Patch set 1 of change I8118d2c932b2a9d6c3d2dae51c5707a6371784d8 has been pushed to the review server.
It is available at http://review.typo3.org/6830
Updated by Steffen Gebert about 13 years ago
- Assignee deleted (
TYPO3 Release Team) - Target version deleted (
4.6.1)
Updated by Gerrit Code Review about 13 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/6830
Updated by Georg Ringer about 13 years ago
is it possible that this is still not fully fixed?
My page tree:
. Tree 1 < -- Domain: fo.local ... Tree 1b . Tree 2 < -- Domain: trunk.local ... Tree 2b
My backend domain: trunk.local and if i am on page "Tree 1b" I still get the trunc.local as preview domain but this should be fo.local as trunk.local is only valid for the other page tree.
problem is imo because ::getDomainStartPage()
will deliver a result for trunk.local but first there should be a check if this domain is valid for the current rootline
Updated by Gerrit Code Review almost 13 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/6830
Updated by Gerrit Code Review almost 13 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/6830
Updated by Gerrit Code Review almost 13 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/6830
Updated by Jaume Prat almost 13 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset bfda58caaa923fe73656fa5febc641486b7dbeec.
Updated by Gerrit Code Review almost 13 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/9317
Updated by Gerrit Code Review almost 13 years ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9319
Updated by Gerrit Code Review almost 13 years ago
Patch set 2 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9319
Updated by Gerrit Code Review almost 13 years ago
Patch set 3 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9319
Updated by Gerrit Code Review almost 13 years ago
Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/9317
Updated by Gerrit Code Review almost 13 years ago
Patch set 4 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9319
Updated by Jaume Prat almost 13 years ago
- Status changed from Under Review to Resolved
Applied in changeset 678b01b790e3fdd3e081715a11728bf42d2439f5.
Updated by Gerrit Code Review almost 13 years ago
- Status changed from Resolved to Under Review
Patch set 3 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/9317
Updated by Jaume Prat almost 13 years ago
- Status changed from Under Review to Resolved
Applied in changeset 09ef6f690e7b9d9cedc6c85ac0d88009697ae79a.