Bug #31333

Redirect to root-page without type if only ?type=xy is specified in url

Added by Markus Blaschke almost 11 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
Start date:
2011-10-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Multiple PAGE-Types configured with TypoScript Setup, eg.:

Foo = PAGE
Foo {
10 = USER
10 ...
typeNum = 123
}

Example, worked until 4.6:

www.example.com/?type=123

With 4.6 the request is redirected to:
www.example.com/index.php?id=22
but without the type-information (and also all other request-informations)!

Please add type- and other-parameters to the redirection.

#1

Updated by Markus Blaschke almost 11 years ago

Maybe only if rootpage is a shortcut to the first subpage?

Currently breaks Extension tq_seo (Sitemap.txt, sitemap.xml, robots.txt) and some tt_news stuff (rss.xml). Maybe other extensions are affected.

#2

Updated by Markus Blaschke over 10 years ago

Confirmed by many tq_seo users who updated to TYPO3 4.6:

If page is a shortcut the http-request is redirected to the target website without any parameters.

#3

Updated by Xavier Perseguers over 10 years ago

  • Priority changed from Should have to Must have
  • Target version set to 4.6.1

Must be analyzed to try to reproduce

#4

Updated by Xavier Perseguers over 10 years ago

Well, I'm not sure that passing ?type=123 automatically is the way to do, after all, if you tell TYPO3 to do so with:

config.linkVars = type

(and possibly with the L parameter as well)

Then it works, so why should we introduce some magic here? A shortcut points to a given page and the default type is 0 regardless of whatever you specify. I'd tend to see the behaviour in TYPO3 4.5 as weird after all.

#5

Updated by Xavier Perseguers over 10 years ago

  • Status changed from New to Accepted
#6

Updated by Mr. Jenkins over 10 years ago

  • Status changed from Accepted to Under Review

Patch set 1 of change I6638d34fcbc1a3862f65783e4ad3a226de1dd3e0 has been pushed to the review server.
It is available at http://review.typo3.org/6775

#7

Updated by Xavier Perseguers over 10 years ago

  • Target version changed from 4.6.1 to 4.6.2
#8

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/6775

#9

Updated by Joël Lachance over 10 years ago

I tried your patch, but the others parameters are striped when the root page is a shortcut...

#10

Updated by Markus Klein over 10 years ago

@Joël: This is not a problem of this patch.
It's a different bug, which gets fixed here: http://forge.typo3.org/issues/32253

#11

Updated by Markus Blaschke over 10 years ago

Seems good but all other parameters are striped (and i don't want them in linkVars) but i can live with this issue.

#12

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/7808

#13

Updated by Xavier Perseguers over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#14

Updated by Xavier Perseguers over 10 years ago

  • Status changed from Resolved to Closed
#15

Updated by Johannes C. Schulz over 10 years ago

Hello

I have big trouble with this.
Before Update to 4.6.4 all worked fine, but now additional parameters are stripped from the URL and so authentication failes, trying to access a page.

the url:
http://www.DOMAIN.de/index.php?type=8800881&username=USERNAME&password=PASSWORD
the redirect goes to:
http://www.DOMAIN.de/homepage/?type=8800881

after applying the patched class.tslib_fe.php the pagetype is kept by the redirect, but username and password are dropped.

I use realURL - maybe there is anything more to do?

#16

Updated by Xavier Perseguers over 10 years ago

  • Status changed from Closed to Under Review
  • Target version changed from 4.6.2 to 4.6.6
#17

Updated by Xavier Perseguers over 10 years ago

  • Status changed from Under Review to Resolved
#18

Updated by Nikolas Hagelstein about 10 years ago

The behavior reportet by Johannes is still existing in TYPO3 4.6.8.
If your rootpage is a shortcut. All additional parameters get striped.

E.g. :

http://DOMAIN.de/?type=123&tx_whatever['foo']=bar

becomes

http://DOMAIN.de/index.php?id=4&type=123

Where id=4 is the target page of the shortcut.

Workarround is to add tx_whatever to linkVars though that's an ugly workarround.

#19

Updated by Riccardo De Contardi almost 5 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF