Bug #32422
closedEncoding error in TCEforms inline JavaScript
0%
Description
The fix introduced for issue #29067 has broken the linkbrowser popup for new elements in sections. The FCE has to be saved in order for the link to work.
See http://screencast-o-matic.com/watch/cXlQ2NvqJ
Files
Updated by Steffen Gebert about 12 years ago
- Priority changed from Must have to Should have
Could you explain it a bit? I don't get your point. Please include all your information here, too. Is this only related to Templavoila?
Updated by Lukas Rüegg about 12 years ago
- File Linkbrowser.pdf Linkbrowser.pdf added
The change made to the TCE forms class from issue #29067 breaks links which open the link browser.
As described this only happens in FCEs which have sections. For example, I have an FCE where i can add elements in a section and there's a field with a link to the link browser in each element of the section. Whenever I add a new element to the section the link to the linkbrowser will not work until I save the FCE.
Although this only happens in TemplaVoila FCEs with sections it is related to TCE Forms and it can be fixed by reverting issue #29067
Updated by Manuel Stofer almost 12 years ago
using json_encode instead of unescape, decodeURIComponent and rawurlencode solves the problem
@see patch
Updated by Steffen Gebert almost 12 years ago
Thanks, Manuel! Could you push this to our review system Gerrit, please? http://wiki.typo3.org/Contribution_Walkthrough
Thanks for your contribution!
Updated by Gerrit Code Review almost 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/8790
Updated by Gerrit Code Review almost 12 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8792
Updated by Gerrit Code Review almost 12 years ago
Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/8790
Updated by Manuel Stofer almost 12 years ago
- File T3X_demo_bug_32422.t3x T3X_demo_bug_32422.t3x added
A small demo of the problem is attached. I hope it helps to review the patch.
Updated by Steffen Gebert almost 12 years ago
- Assignee set to Steffen Gebert
- Target version set to 4.5.12
Great, thanks a lot! I appreciate that you made the review so easy by creating the extension!
Updated by Steffen Gebert almost 12 years ago
- Subject changed from Fix for bug #29067 introduces new bug to Encoding error in TCEforms inline JavaScript
Updated by Gerrit Code Review almost 12 years ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/8831
Updated by Steffen Gebert almost 12 years ago
- Status changed from Under Review to Resolved
Updated by Helmut Hummel almost 12 years ago
This solution still does not work for forceCharset anything different to utf-8. json_encode fails when specail characters are present.
The php manual clearly states that json_encode only works for utf-8: http://www.php.net/manual/en/function.json-encode.php
Updated by Riccardo De Contardi about 6 years ago
- Status changed from Resolved to Closed